Bug #5217

Institutional Edit Theme page: a logo or banner cannot be replaced after 1 has been uploaded

Added by Dan Gillean almost 9 years ago. Updated over 8 years ago.

Status:Won't fixStart date:06/10/2013
Priority:MediumDue date:
Assignee:José Raddaoui Marín% Done:

0%

Category:RepositoryEstimated time:2.00 hours
Target version:Release 2.0.0
Google Code Legacy ID: Tested version:
Sponsored:No Requires documentation:

Description

To Reproduce
Log in as an administrator
Navigate to a repository and select Edit theme
Upload a logo, save description.
Select Edit theme again, click the checkbox to remove the logo. Save - review that the logo is now gone.
Select Edit theme yet again, and try to upload a different logo

Resulting Error
The first logo and/or banner uploaded returns

Expected Result
New logo/banner is uploaded


Related issues

Related to Access to Memory (AtoM) - Bug #4629: Institutional Edit theme page: User should receive warnin... Verified 02/04/2013
Related to Access to Memory (AtoM) - Feature #3898: Enhance multi-institutional portal functionality - allow ... Verified

History

#1 Updated by Dan Gillean almost 9 years ago

  • Priority changed from Medium to Low

I've discovered that this is in fact a browser cache issue. If you clear the browser cache and reload the page, the new icon appears. I'm not sure if there is a way to change something to make this issue less likely to happen (force page reload? etc.) within AtoM itself, or if I should just mark this issue as invalid - so I will leave it for now. Bumping to Low priority.

#2 Updated by Jessica Bushey almost 9 years ago

  • Priority changed from Low to Medium

#3 Updated by Jesús García Crespo almost 9 years ago

  • Estimated time set to 2.00

#4 Updated by Jesús García Crespo over 8 years ago

  • Assignee changed from Jesús García Crespo to José Raddaoui Marín

#5 Updated by Dan Gillean over 8 years ago

See #3898 for additional notes on usability for this issue - comments on that issue were duplicating this one so i've closed it, but there is some useful information there - which could conceivably become its own issue ticket if needed.

#6 Updated by José Raddaoui Marín over 8 years ago

We're always storing the banner/logo in the same route and with the same file name, so the browser thinks that nothing has changed in the page. Only refreshing the page reloads the images.

We can try something like this ([[http://symfony.com/legacy/doc/gentle-introduction/1_4/en/12-Caching#chapter_12_http_1_1_and_client_side_caching]]) or use a different route/name for the new images, but I don't think it worth the time.

#7 Updated by José Raddaoui Marín over 8 years ago

  • Status changed from New to QA/Review

#8 Updated by Dan Gillean over 8 years ago

  • Status changed from QA/Review to Won't fix

Agreed, I don't wanna spend too much time on an issue that doesn't affect functionality. A hard reload of the page (CTRL +R in firefox for example) will make the changes apparent - I will add this to the documentation at the appropriate place.

Also available in: Atom PDF