Access to Memory (AtoM)

Also, on iPhone for both Dominion and Archives Canada themes (including on the beta site), the menu links in the top right corner don't appear, e.g. login and language options.

Just an update - I was able to reproduce the reported iPhone behaviour using Chrome on an iPhone as well as Safari.

You can reproduce part of this on a non-mobile browser. Reduce the width of the browser screen until the login etc. buttons disappear. At that point, the site logo is no longer hyperlinked.

There's a visual hint what's happening on the AC beta site - reduce the screen width until the "beta" image overlaps the CCA swoosh. That portion of the image will no longer be hyperlinked (which is what you get on a iPhone, portrait orientation).

The pull-down browse links issue seems to be unrelated - those still work in the non-mobile browser.

I have just run into this issue which is further complicated by the fact that when the user actually clicks into the login box area the device freezes for a couple of seconds and then bombs out of Safari altogether. I have successfully replicated this on http://demo.accesstomemory.org/ on an iPad Mini.

https://github.com/twbs/bootstrap/issues/5835 seems to indicate that this is a bug with an earlier version of Bootstrap.

Potential fix and pull request https://github.com/artefactual/atom/pull/2

Nice catch, Kehan. Upgrading bootstrap to 2.3.2 also fixes the issue with pull-down browse button. But I still can't see the login/language area of the screen, and the home page link also doesn't work. That's testing on an iPhone.

Incidentally I also tried bootstrap 3.0.3, but that broke the pull-down browse list in IE (desktop).

Amazing! Thanks for the pull request, Kehan! Always appreciate your contributions. Jesus is swamped with client work, but I'll try to have one of our developers look at your pull request soon. Glad to hear it will solve a few of these issues - but I imagine this ticket will stay open so we can track and address the remaining mobile layout problems in a future release.

As a quick note - I am going to want to do a lot of regression testing on this, before we accept the pull request, to make sure that this is not accidentally breaking any layout/formatting/etc. elements elsewhere in the application. However, Kehan and Tim - if you have both applied this to your local environments, I'll be curious to hear about how it holds up throughout the rest of the application - let me know if you encounter any issues/regressions. Thanks.

So far I haven't come across any problems.

Some further progress... while it's the language and user menus that disappear, it turns out that the problem with the home page link not working boils down to the search-bar div. Removing this line in min.css:
#search-bar{white-space:nowrap;position:relative;}
makes the home page link work, and doesn't seem to have any ill effects on desktop browsers (tested with FF 26, Chrome 32, IE 11)

The user menu etc. still disappears – I think search-bar is still involved but I’m not fluent enough with css to figure out how.

I agree that this does need testing. I hadn't noticed that the home link wasn't working but I did notice that the user menu etc still don't appear unless the device is in landscape view. I propose that the whole top bar gets replaced with bootstrap's .nav-bar or .nav-bar-top class because then bootstrap can convert the menu items into mobile device friendly compacted menus, but that was a much more significant change than the one in the pull request ;) Looking at the history of header.less (where the #searchbar{... above comes from https://github.com/artefactual/atom/commit/5ca860367369084947fb359bfa22c882d04b9207 which aimed at making the search bar more responsive so I guess we just need to be aware of that.

header.less line 362 the nav buttons get actively hidden with :
nav {
.hide();
}

But that was also part of addition ('Restore responsive properties (Dominon Header)') of responsive design in commit 414c05542e1a7d85bc597ae5ff785b2b567a24aa

Right, from my earlier testing it looks like the home page link not working occurs only with the iPhone, not iPad. But I'm able to reproduce it on a desktop by reducing the width of the browser window until the login etc. buttons disappear.

Dan, I've merged Kehan's PR: https://github.com/artefactual/atom/pull/2.
Thank you everyone! I can cherry-pick the changes into stable/2.0.x (for 2.0.2) too if Dan verifies.

I have done some initial regression testing in the site, and so far the only glitch I found that may have been caused by the Bootstrap upgrade was a change in the width of the dedicated search boxes available on the Institutions, Subjects, Places, Authority records, Users, etc etc etc pages. Jesus has already pushed a commit to address this - see: https://github.com/artefactual/atom/commit/6146f0ecca4dc8a992fabac312482b7a44a13b46

So far I haven't found any other problems caused by the Bootstrap update. Thanks again Kehan.