Bug #5895

Global search throws 500 error when non-integer string appears in repos parameter

Added by Dan Gillean over 8 years ago. Updated over 8 years ago.

Status:VerifiedStart date:10/30/2013
Priority:HighDue date:
Assignee:José Raddaoui Marín% Done:

100%

Category:Multi-institution
Target version:Release 2.0.1
Google Code Legacy ID: Tested version:
Sponsored:No Requires documentation:

Description

1) conduct a global search for "foo" --> the url returned will be: "http://2x.test.artefactual.com/search?query=foo&repos="
2) conduct a search for "foo" restricted to a specific repository --> the url returned will be something like "http://2x.test.artefactual.com/search?query=foo&repos=90954", where the repos parameter represents a value assigned to a specific repository created in AtoM.
3) edit the url to say "http://2x.test.artefactual.com/search?query=foo&repos=xxx"

resulting error
repos parameter is not parsed, user receives a 500 error

expected result
When encountering an unknown number or a parameter that is not an integer, the parameter should be ignored (resulting in a global search) rather than leading to an error.

Note that an error occurs if an integer too large is used as well - for example 6666666666666 will produce a 500 error. Again, any parameter that does not match an existing parameter should be ignored, rather than causing a server error.

History

#1 Updated by José Raddaoui Marín over 8 years ago

  • Status changed from New to QA/Review
  • % Done changed from 0 to 100

AtoM|commit: bef630f84e8a368db6388db5bc452b36f93bbe1f

#2 Updated by Dan Gillean over 8 years ago

  • Status changed from QA/Review to Verified

Also available in: Atom PDF