Bug #6114

Update sfToolkit to use preg_replace_callback instead of /e modifier

Added by Jesús García Crespo over 8 years ago. Updated about 7 years ago.

Status:VerifiedStart date:12/12/2013
Priority:HighDue date:
Assignee:Dan Gillean% Done:

0%

Category:-Estimated time:2.00 hours
Target version:Release 2.2.0
Google Code Legacy ID: Tested version:
Sponsored:No Requires documentation:

Description

It seems that this is the only missing piece of our copy of Symfony 1.4 still using the /e modifier.
Only E_DEPRECATED is emitted in PHP 5.5, but we should fix it anyways.

Deprecated: preg_replace(): The /e modifier is deprecated, use preg_replace_callback instead in /home/jesus/www/atom-2/vendor/symfony/lib/util/sfToolkit.class.php on line 362

Related issues

Related to Access to Memory (AtoM) - Bug #5761: Populating search from command line gives PHP Fatal error Verified 10/08/2013

History

#1 Updated by Jesús García Crespo over 7 years ago

  • Target version changed from Release 2.0.2 to Release 2.1.0

#2 Updated by Jesús García Crespo over 7 years ago

  • Target version changed from Release 2.1.0 to Release 2.2.0

#3 Updated by Sarah Romkey about 7 years ago

  • Assignee changed from Jesús García Crespo to José Raddaoui Marín
  • Priority changed from Medium to High

Hi Radda- could you please take a look, and consult with Jesus if necessary?

#4 Updated by José Raddaoui Marín about 7 years ago

It looks like this may have been already fixed:

https://github.com/artefactual/atom/blob/qa/2.2.x/vendor/symfony/lib/util/sfToolkit.class.php#L364

But I've found a couple of places where the /e modifier is used:

https://github.com/artefactual/atom/blob/qa/2.2.x/vendor/symfony/lib/task/sfTask.class.php#L307
https://github.com/artefactual/atom/blob/qa/2.2.x/vendor/symfony/lib/plugins/sfDoctrinePlugin/lib/vendor/doctrine/Doctrine/Adapter/Statement/Oracle.php#L586

Not sure if the one in the Doctrine plugin for Oracle worths the time as we use Propel and MySql, but we may want to fix the one in sfTask.

#5 Updated by José Raddaoui Marín about 7 years ago

  • Status changed from New to Code Review
  • Assignee changed from José Raddaoui Marín to Jesús García Crespo

PR 130

#6 Updated by Jesús García Crespo about 7 years ago

  • Status changed from Code Review to QA/Review
  • Assignee changed from Jesús García Crespo to Dan Gillean

Let's test in php5.3 and php5.5. Make sure that tasks are working on both versions, because the latest change is making one change in that area of the application. See 5d4a5d1b4342f7181f49c007258baf701fa5d02e.

I'll show you how to test on php5.3.

#7 Updated by Jesús García Crespo about 7 years ago

  • Status changed from QA/Review to Verified

Also available in: Atom PDF