Bug #6748

Dominion theme won't compile with current version of less

Added by Justin Simpson almost 8 years ago. Updated over 7 years ago.

Status:VerifiedStart date:05/22/2014
Priority:MediumDue date:
Assignee:David Juhasz% Done:

0%

Category:CSS/HTML
Target version:Release 2.1.0
Google Code Legacy ID: Tested version:
Sponsored:No Requires documentation:

Description

The css in the Dominion theme should be updated to work with the most recent version of less.

Installation instructions for Atom 2 explain how to compile the css in Atom themes like so:

sudo add-apt-repository ppa:chris-lea/node.js
sudo apt-get update
sudo apt-get install nodejs
sudo npm install -g less
cd /usr/share/nginx/atom/plugins/arDominionPlugin/
sudo -u www-data make

These instructions no longer work, because the version of less that gets installed by npm is 1.6.x, and the css in the arDominionPlugin only works with less 1.3.3 or earlier.

here is the error that happens when you use a modern less:

Running LESS compiler...

lessc --compress --relative-urls css/main.less > css/min.css

ParseError: Unrecognised input in /data/rbsc/icaatom-2.0.2/vendor/bootstrap/less/mixins.less on line 558, column 3:

557
558   .core (@gridColumnWidth, @gridGutterWidth) {
559

make: *** [less] Error 1

History

#1 Updated by Dan Gillean almost 8 years ago

I have updated the instructions on the documentation so that they say: now, which is the compatible version. But this isn't a long-term solution. Ideally, we should update less in AtoM to 1.6x

#2 Updated by Jesús García Crespo over 7 years ago

  • Target version changed from Release 2.0.2 to Release 2.1.0

#3 Updated by Jesús García Crespo over 7 years ago

  • Target version changed from Release 2.1.0 to Release 2.2.0

#4 Updated by Jesús García Crespo over 7 years ago

  • Status changed from New to Verified
  • Target version changed from Release 2.2.0 to Release 2.1.0

This one was fixed by our best contributor, @kehan! See his pull request.

I made it available in stable/2.0.x too.

#5 Updated by David Juhasz over 7 years ago

Awesome! Thanks Kehan! :D

#6 Updated by David Juhasz over 7 years ago

And thanks Jesús for merging to stable/2.0.x :)

Also available in: Atom PDF