Bug #6802

Language and script notes are not removed from view page after deletion

Added by Dan Gillean about 6 years ago. Updated almost 3 years ago.

Status:VerifiedStart date:06/09/2014
Priority:HighDue date:
Assignee:-% Done:

0%

Category:Information object
Target version:Release 2.4.0
Google Code Legacy ID: Tested version:2.2, 2.2.1
Sponsored:No Requires documentation:

Description

To reproduce
  • Create a new description or navigate to an existing one, and enter edit mode
  • Add data to the Language and script notes field, on the RAD template (under Notes Area)
  • Save the record
  • Enter edit mode again, and remove the data. Save.

Error encountered
Though the data in the field has been deleted by the user, it still shows when in view mode.

Expected result
When the user deletes data in edit mode, it should no longer be visible when in view mode.

This error was encountered in the RAD template, but the field is common across several templates, and we should ensure it works as expected on all of them as well.

History

#1 Updated by Dan Gillean about 6 years ago

  • Priority changed from Medium to High

Retested and reconfirmed. Tried clearing browser cache; tried opening in a different browser to view - language and script notes that should have been deleted are still visible. Bumping up to high.

#2 Updated by Dan Gillean almost 6 years ago

  • Tested version 2.0.1 added

#3 Updated by Jesús García Crespo almost 6 years ago

  • Status changed from New to QA/Review
  • Assignee changed from Jesús García Crespo to Dan Gillean

I can't reproduce this. Let's take a look together on Monday.

#4 Updated by Dan Gillean almost 6 years ago

  • Status changed from QA/Review to In progress
  • Assignee changed from Dan Gillean to Jesús García Crespo
  • Tested version 2.0.0 added

#5 Updated by Jesús García Crespo almost 6 years ago

  • Status changed from In progress to QA/Review
  • Assignee changed from Jesús García Crespo to Dan Gillean

Fixed in ab6e0bab60.

#6 Updated by Dan Gillean almost 6 years ago

  • Status changed from QA/Review to Verified

#7 Updated by Edgar Rodríguez Silva about 5 years ago

The bug occurs in the ISAD template too, I used the code produced by Jesús García to solve it but in file plugins/sfIsadPlugin/lib/sfIsadPlugin.class.php

#8 Updated by David Juhasz about 5 years ago

  • Subject changed from Langauge and script notes are not removed from view page after deletion to Language and script notes are not removed from view page after deletion

Fix typo in title

#9 Updated by Dan Gillean almost 4 years ago

  • Status changed from Verified to Feedback
  • Assignee deleted (Dan Gillean)
  • Target version changed from Release 2.1.0 to Release 2.4.0
  • Tested version 2.2, 2.2.1 added

Reported in the user forum on 2016-08-11 in version 2.2.0 using the ISAD template, and confirmed in the 2.2.1 demo site.

Note Edgar's comments above - it looks like we didn't apply this to all relevant templates. We should re-use the solution as Edgar suggests and ensure it is applied to DACS and ISAD as well.

#10 Updated by Nick Wilkinson over 3 years ago

  • Assignee set to José Raddaoui Marín

Hi Radda, assigning this for you to look into.

#11 Updated by José Raddaoui Marín over 3 years ago

  • Status changed from Feedback to Code Review
  • Assignee changed from José Raddaoui Marín to Nick Wilkinson

#12 Updated by Nick Wilkinson over 3 years ago

  • Assignee changed from Nick Wilkinson to Mike Cantelon

#13 Updated by Mike Cantelon over 3 years ago

  • Status changed from Code Review to Feedback
  • Assignee changed from Mike Cantelon to José Raddaoui Marín

Looks good to me!

#14 Updated by José Raddaoui Marín over 3 years ago

  • Status changed from Feedback to QA/Review
  • Assignee changed from José Raddaoui Marín to Dan Gillean

Merged in qa/2.4.x

#15 Updated by Dan Gillean about 3 years ago

  • Assignee deleted (Dan Gillean)

#16 Updated by Kelly Stewart almost 3 years ago

  • Status changed from QA/Review to Verified

Also available in: Atom PDF