Bug #6951

Website link in institutional contact sidebar adds current site as a prefix

Added by Evelyn McLellan almost 8 years ago. Updated about 7 years ago.

Status:VerifiedStart date:07/08/2014
Priority:MediumDue date:
Assignee:Dan Gillean% Done:

0%

Category:Routing
Target version:Release 2.2.0
Google Code Legacy ID: Tested version:
Sponsored:No Requires documentation:

Description

See attached screenshot. Clicking on the "Website" button in the right-hand sidebar should open www.peanut.com but actually tries to open 2x.text.artefactual.com/www.peanut.com. Note that the URL link in the Contacts area works properly.

ISDIAH.png (115 KB) Evelyn McLellan, 07/08/2014 03:22 PM

History

#1 Updated by Dan Gillean almost 8 years ago

  • Priority changed from High to Low

Note: this is only the case if the user does NOT add http:// as a prefix. Evelyn, I edited your contact information on the test institution, and changed it to http://www.peanut.com. The link now works as expected. I will try to add a note about this to our documentation soon. It would be nice to fix it so that wasn't necessary, but I have changed the priority of this issue to low - will leave it to David to determine if we change this to Won't fix or not.

#2 Updated by Evelyn McLellan almost 8 years ago

Thanks, Dan. Users probably won't find that info in the documentation, so if it's a "won't fix", maybe the field label could be changed from "URL" to "URL (must include http://)".

#3 Updated by Evelyn McLellan almost 8 years ago

Or maybe make it a tooltip instead?

#4 Updated by Dan Gillean almost 8 years ago

  • Priority changed from Low to Medium

I like these suggestions. Marking back up to medium for now.

#5 Updated by Jesús García Crespo over 7 years ago

  • Target version changed from Release 2.1.0 to Release 2.2.0

#6 Updated by Mike Gale about 7 years ago

  • Assignee changed from David Juhasz to Mike Gale

#7 Updated by Mike Gale about 7 years ago

  • Status changed from New to Code Review
  • Assignee changed from Mike Gale to José Raddaoui Marín

Maybe this didn't need its own branch/PR, but...

https://github.com/artefactual/atom/commit/7b2f1077369796b20e8ff413204d850b034ac251

Sorry about the messy PR, an extra commit got in there because I forgot to switch to qa/2.2.x before making the new branch. I'll just cherry-pick the one commit if it's OK.

#8 Updated by José Raddaoui Marín about 7 years ago

  • Status changed from Code Review to Feedback
  • Assignee changed from José Raddaoui Marín to Mike Gale

#9 Updated by Mike Gale about 7 years ago

  • Status changed from Feedback to QA/Review
  • Assignee changed from Mike Gale to Dan Gillean

#10 Updated by Dan Gillean about 7 years ago

  • Status changed from QA/Review to Verified

this is interesting to me.... that we were asking for a tooltip, and you added a different fix instead. but it works.

Tested with random.com - which will lead to a domain squatter's page, so it resolves.

If you enter just "random.com" into the field, the sidebar website button will still work, and it will take you to http://random.com. However, the view page text will not automatically become a hyperlink (because it's looking for the http:// to generate a hyperlink automatically). This is good, because it gives a visual cue to the user that they can fix if they wish, without breaking the sidebar link funcitonality.

If you edit it and add http://, it will still work - e.g. the sidebar will not accidentally try to take you to http://http://random.com.

Marking verified. Thanks!

Also available in: Atom PDF