Feature #7122

Display notice with hyperlink at top of description when translated content exists.

Added by Dan Gillean almost 8 years ago. Updated over 7 years ago.

Status:VerifiedStart date:08/19/2014
Priority:MediumDue date:
Assignee:Dan Gillean% Done:

100%

Category:I18NEstimated time:6.00 hours
Target version:Release 2.1.0
Google Code Legacy ID: Tested version:2.0.1, 2.1
Sponsored:Yes Requires documentation:

Description

Indicate to users that translations are available. When user clicks hyperlink, AtoM will flip user interface to selected language, and display translated content.

language-dropdown.png (90.2 KB) Dan Gillean, 09/10/2014 09:43 AM

History

#1 Updated by José Raddaoui Marín over 7 years ago

  • Status changed from New to Code Review
  • Assignee changed from José Raddaoui Marín to Jesús García Crespo
  • % Done changed from 0 to 100

PR: 42

#2 Updated by Jesús García Crespo over 7 years ago

  • Status changed from Code Review to Feedback
  • Assignee changed from Jesús García Crespo to José Raddaoui Marín

#3 Updated by José Raddaoui Marín over 7 years ago

  • Status changed from Feedback to Code Review
  • Assignee changed from José Raddaoui Marín to Jesús García Crespo

#4 Updated by José Raddaoui Marín over 7 years ago

  • Status changed from Code Review to QA/Review
  • Assignee changed from Jesús García Crespo to Dan Gillean
  • Target version changed from Release 2.2.0 to Release 2.1.0

#5 Updated by Dan Gillean over 7 years ago

Initial testing locally looks good. Requires restart of php5-fpm and rebuilding of search index for testing on 2x - I want to review a bit more there to ensure everything is as expected on a larger set of material.

#6 Updated by Jesús García Crespo over 7 years ago

Should we make the list a drop-down? Also, Radda can you show the language instead of the ISO code?

#7 Updated by Dan Gillean over 7 years ago

Oooh, that would would be fancy and nice! Sure :)

#8 Updated by Dan Gillean over 7 years ago

  • Status changed from QA/Review to Feedback
  • Assignee changed from Dan Gillean to José Raddaoui Marín

#9 Updated by José Raddaoui Marín over 7 years ago

  • Status changed from Feedback to Code Review

PR: 49

#10 Updated by José Raddaoui Marín over 7 years ago

  • Assignee changed from José Raddaoui Marín to Jesús García Crespo

#11 Updated by Jesús García Crespo over 7 years ago

  • Status changed from Code Review to QA/Review
  • Assignee changed from Jesús García Crespo to Dan Gillean

Radda, PR49 was breaking because you were passing to sf_culture the value returned by format_language() instead of the language code. I've fixed that and merged it.

Something that I've noticed is that it's been implemented only for archival descriptions. We should make this same feature available for other entities and move the component to the default/ module. After all this is based on attributes of the objects that are not specific to information objects but common across many entities in AtoM.

#12 Updated by Dan Gillean over 7 years ago

  • File language-dropdown.png added
  • Status changed from QA/Review to Feedback
  • Assignee changed from Dan Gillean to José Raddaoui Marín

I agree that it would be great to extend this to other entities - I tested on authority records, and noticed that it does not work there. I assumed that was beyond the scope of the work, but if we can do it we should, to make the experience consistent across the app - especially if we are applying #7120 to multiple entities.

Regarding this: I noticed that it will no longer display the language of the default culture. Meaning I have no indication that English is available in qa/2.1.x for example.

Resulting error
On archival description view page, if viewed in French and English is available, it should be shown in the language drop-down, regardless of what the default descriptive language or default application culture is.

#13 Updated by Dan Gillean over 7 years ago

Basically the dropdown is displaying the CURRENT language, rather than the other language available.

If we really can add this to other entities where the unique docs feature (#7120) has also been added, this will solve a VAST number of the multilingual problems in AtoM !!! The combination of the 2, working properly, will make working with multilingual content MUCH better. I really hope we can add this to other entities.

#14 Updated by José Raddaoui Marín over 7 years ago

  • Status changed from Feedback to Code Review
  • Assignee changed from José Raddaoui Marín to Jesús García Crespo

Hi, the drop-down is now showing all existing cultures except the current one, and I've submited a pull request that adds the drop-down in other entities (PR: 50)

I've added it to the entities that can be in other cultures and have and index page (excep taxonomies, wich index page is only to show the terms):

- Information objects
- Authority records
- Archival institutions
- Functions
- Physical objects
- Rights holders
- Terms
- Accessions
- Deaccessions
- Donors

#15 Updated by Jesús García Crespo over 7 years ago

  • Status changed from Code Review to QA/Review
  • Assignee changed from Jesús García Crespo to Dan Gillean

Looking a lot better now, thanks! Merged.

#16 Updated by Dan Gillean over 7 years ago

  • Status changed from QA/Review to Verified

This is great. Works as expected now. Thanks so much! With this and #7120, multilingual use just got a lot better in AtoM.

Also available in: Atom PDF