Bug #7242

EAD <archdesc> element does not include required LEVEL attribute if description has no level

Added by Dan Gillean over 7 years ago. Updated over 7 years ago.

Status:VerifiedStart date:09/15/2014
Priority:MediumDue date:
Assignee:Dan Gillean% Done:

0%

Category:EAD
Target version:Release 2.1.0
Google Code Legacy ID: Tested version:2.1
Sponsored:No Requires documentation:

Description

Now that we have fixed a bug that was preventing the EAD DTD from being called to check the validity of the EAD, we are finding a few small fixes that need to happen to our EAD export.

Currently libxml will spit out the following warning:

Warnings were encountered:
libxml error 518 on line 24 in input file: Element archdesc does not carry attribute level

We are missing the required @LEVEL attribute on the <archdesc> element. The <archdesc> element appears only once in the EAD file, as the top-level of description - after that, nested <c> elements are used.

According to the EAD Tag Library 2002:

The <archdesc> element has several specialized attributes. The required LEVEL attribute identifies the character of the whole unit, for example, "class," "collection," "fonds," "recordgrp," "series," "subfonds," "subgrp," "subseries," or "otherlevel." This attribute is comparable to ISAD data element 3.1.4 and MARC field 351 subfield c.

We should add this attribute to ensure EAD XML 2002 compliance.

See: http://www.loc.gov/ead/tglib/elements/archdesc.html

7242-fix.patch Magnifier (3.33 KB) Mike Gale, 09/15/2014 09:05 PM

History

#1 Updated by Dan Gillean over 7 years ago

  • Description updated (diff)

[fix description]

#2 Updated by Jesús García Crespo over 7 years ago

  • Status changed from New to In progress
  • Assignee changed from Mike Gale to Jesús García Crespo
  • Target version changed from Release 2.1.1 to Release 2.1.0

#3 Updated by Jesús García Crespo over 7 years ago

  • Assignee changed from Jesús García Crespo to Mike Gale

#4 Updated by Dan Gillean over 7 years ago

  • Subject changed from EAD <archdesc> element does not include required LEVEL attribute to EAD <archdesc> element does not include required LEVEL attribute if description has no level
  • Status changed from In progress to New

Okay okay, figured out the source of this error...

we are actually including this in the EAD. In the test case reported by a developer, no level was assigned in AtoM. I've updated the title of the issue ticket to reflect this.

We're going to create a fix where if no level is included in AtoM, @LEVEL is assigned to "otherlevel" so it is still compliant. Will try to do tonight, and get it into 2.1.

#5 Updated by Mike Gale over 7 years ago

I didn't have time to fix my SSH key situation, so here's another patch! :P

I refactored a bunch of the code so level= rendering is a lot more clear now. And since <c level=...> and <archdesc level=...> were using duplicate code, I made <c> tags use the same method... so now <c> tags will have more otherlevel info (I checked the EAD standard, the level= isn't REQUIRED like in archdesc, but it's OK if it's there)

And Jesús if you take a look at those lines I replaced, you might get a chuckle :)

cheers

#6 Updated by Jesús García Crespo over 7 years ago

  • Status changed from New to QA/Review
  • Assignee changed from Mike Gale to Dan Gillean

#7 Updated by Sarah Romkey over 7 years ago

  • Status changed from QA/Review to Verified

Also available in: Atom PDF