Bug #7278

Do not convert extent sub-elements to HTML definition list on EAD import

Added by Sarah Romkey over 7 years ago. Updated about 7 years ago.

Status:VerifiedStart date:09/19/2014
Priority:MediumDue date:
Assignee:Dan Gillean% Done:

0%

Category:Import/Export
Target version:Release 2.2.0
Google Code Legacy ID: Tested version:2.1
Sponsored:No Requires documentation:

Description

On roundtrip, the attached EAD file changed the extent tag to:

<extent encodinganalog="1.5B1">
<dl><dt>Extent</dt><dd>Stuff & stuff & more things like * $ # @ ^ !</dd></dl>
</extent>

The <dl>,<dt> and <dd> tags were not present on export from AtoM, so it's unclear what created them on import.

alexander-imich-fonds;ead.xml Magnifier (6.95 KB) Sarah Romkey, 09/19/2014 01:59 PM

AtoM2.2PhysdescandExtentissuesmeeting2015-02-11.pdf - Meeting notes for plan to resolve physical description mapping issue (150 KB) Dan Gillean, 02/11/2015 04:51 PM


Related issues

Related to Access to Memory (AtoM) - Bug #6003: DACS Technical access field doesn't roundtrip (EAD export... New 11/20/2013
Related to Access to Memory (AtoM) - Bug #5212: EAD <dimensions> element fails to import into AtoM Verified 06/10/2013
Related to Access to Memory (AtoM) - Bug #5340: Extent field adding text upon EAD import Verified 07/12/2013

History

#1 Updated by Jesús García Crespo over 7 years ago

  • Target version changed from Release 2.1.1 to Release 2.2.0

#2 Updated by Dan Gillean over 7 years ago

For context:

The definition list tags added are a result of a hacky fix introduced with #5212. With XSS escaping coming to AtoM in 2.2 (#7647) this solution will no longer work. We have recently had an internal meeting to discuss this - once I have internal approval, I will post the notes of the meeting here, and we can either use this ticket to implement the solution, or file a new ticket and close this one.

Also related: #5340, #5867, #6246

Once we have our 2.2 fix in place, I think we should close any of the above issues still open. We can always open new issues in the future if needed, but much of the discussion in those tickets will no longer apply after we implement a fix for this.

#3 Updated by Dan Gillean over 7 years ago

Attaching notes from a meeting held to outline the issue, brainstorm possible solutions and challenges, and decide on an approach.

#4 Updated by David Juhasz over 7 years ago

  • Subject changed from Roundtripped EAD adds tags to Exent to Do not convert extent sub-elements to HTML definition list on EAD import

#5 Updated by Nick Wilkinson over 7 years ago

  • Assignee changed from Mike Gale to José Raddaoui Marín
  • Priority changed from High to Medium

Hi Radda, can you please look into this?

#6 Updated by José Raddaoui Marín about 7 years ago

  • Status changed from New to Code Review
  • Assignee changed from José Raddaoui Marín to Mike Gale

Created PR 112

#7 Updated by Mike Gale about 7 years ago

  • Assignee changed from Mike Gale to José Raddaoui Marín

Looks good

#8 Updated by José Raddaoui Marín about 7 years ago

  • Status changed from Code Review to QA/Review
  • Assignee changed from José Raddaoui Marín to Dan Gillean

#9 Updated by Dan Gillean about 7 years ago

  • Status changed from QA/Review to Verified

Amazing! The great part is, if you export DC XML, the physdesc nested tags (which come out in DC in the <format> element) are stripped prior to export (though their contents are not), meaning that DC is not broken by this fix.

#10 Updated by José Raddaoui Marín about 7 years ago

  • Related to Bug #6003: DACS Technical access field doesn't roundtrip (EAD export/import) added

#11 Updated by Dan Gillean almost 7 years ago

  • Related to Bug #5212: EAD <dimensions> element fails to import into AtoM added

#12 Updated by Dan Gillean almost 7 years ago

  • Related to Bug #5340: Extent field adding text upon EAD import added

Also available in: Atom PDF