Bug #7287

CSV import displays QubitPatternRouting warnings

Added by Sarah Romkey over 7 years ago. Updated almost 6 years ago.

Status:VerifiedStart date:09/22/2014
Priority:MediumDue date:
Assignee:Dan Gillean% Done:

0%

Category:CSV import
Target version:Release 2.3.0
Google Code Legacy ID: Tested version:2.1
Sponsored:No Requires documentation:

Description

CSV files import but throw this error:

Warnings were encountered:

QubitPatternRouting Connect sfRoute "sfInstallPlugin/help" (http://accesstomemory.org/wiki/index.php?title=Installer_warnings)
QubitPatternRouting Connect sfRoute "sfInstallPlugin/help" (http://accesstomemory.org/wiki/index.php?title=Installer_warnings)
QubitPatternRouting Match route "homepage" (/) for / with parameters array ( 'module' => 'staticpage', 'action' => 'home', 'slug' => 'home',)

PHP Strict Standards: Non-static method QubitFlatfileImport::createActor() should not be called statically in /usr/share/nginx/atom/lib/QubitFlatfileImport.class.php on line 1149

remove_routing_warnings.patch Magnifier (361 Bytes) Mike Gale, 05/15/2015 03:34 PM

QubitPatternRouting.png (55.6 KB) Tim Hutchinson, 09/18/2015 11:06 AM

weird-blank-warning.png (13 KB) Dan Gillean, 05/12/2016 05:41 PM

History

#1 Updated by Jesús García Crespo over 7 years ago

The QubitPatternRouting messages are fine, we should hide them but they are not errors, I think it's just a result of invoking CLI tasks from the web stack and having the logger factory throwing too much details to stdout. The last one on line 1149 is due to an invocation of a method as an static one, but we can fix that later.

#2 Updated by Mike Gale over 7 years ago

Note that I've already fixed the PHP strict standards error, see: https://github.com/artefactual/atom/commit/570f352ce54ee15145d297ad6fdf57cec6ff3001

#3 Updated by Dan Gillean over 7 years ago

  • Priority changed from Medium to High
  • Target version changed from Release 2.1.1 to Release 2.2.0

Bumping this to high because we are starting to see User Forum posts about this.

#4 Updated by David Juhasz over 7 years ago

  • Assignee deleted (Jesús García Crespo)
  • Priority changed from High to Low
  • Target version deleted (Release 2.2.0)

Downgrading to "Low" as it's just a warning and not actually breaking anything.

#5 Updated by David Juhasz over 7 years ago

  • Subject changed from CSV import errors to CSV import displays QubitPatternRouting warnings

#6 Updated by Mike Gale about 7 years ago

  • Status changed from New to Code Review
  • Assignee set to Jesús García Crespo

#7 Updated by Mike Gale about 7 years ago

#8 Updated by Jesús García Crespo about 7 years ago

  • Status changed from Code Review to Feedback
  • Assignee changed from Jesús García Crespo to Mike Gale

I would just do that in the CLI frontend.

#9 Updated by Tim Hutchinson over 6 years ago

In qa/2.3, I'm running into this as an error, and the description does not import (screenshot attached).

We still have an older version of qa/2.2 running, and in that case I get a warning as outlined above.

#10 Updated by Dan Gillean over 6 years ago

Hey Tim,

Have you rebased recently? We've recently added some code to the qa/2.3.x branch that should make older CSV templates backwards compatible with the changes in 2.3. There are a number of minor fixes included in #8844 as well that might help.

#11 Updated by Tim Hutchinson over 6 years ago

Hi Dan - we just updated this instance a week ago; is the code you're talking about fresher than that? Now that you mention it I was using an older template. But I retested with the current 2.2 sample CSV from the wiki and got the same thing.

We are also running php 5.3, but I haven't come across the error reported on the current user forum thread, and as I mentioned with qa/2.2 the import succeeds with warnings.

#12 Updated by Dan Gillean over 6 years ago

Hmmm, it appears that Radda added that code more than a week ago... https://github.com/artefactual/atom/commit/34027eeac3a7b96e107ee80172155c6f128941ba

Do you get the same problems if you try using the sample included in lib/task/import/example/rad?

#13 Updated by Tim Hutchinson over 6 years ago

Yes, same result on the 2.3/qa site.

#14 Updated by Tim Hutchinson over 6 years ago

I've now had a chance to test on a recent dev branch with upgraded php (offhand I'm not sure if it's 5.4 or 5.5). The import worked as expected - warnings, not errors - so I can confirm that the behaviour I reported above was a php version issue. As you were :)

#15 Updated by Dan Gillean over 6 years ago

Glad to hear it, Tim!

#16 Updated by Dan Gillean over 6 years ago

  • Assignee changed from Mike Gale to Jesús García Crespo

Jesus - so.... look: Mike G. already fixed the PHP strict standard error issues, as mentioned in comment 2 above. Users get confused as hell when they see these warnings. In Mike's years here (or mine), I can't think of an instance we had to troubleshoot where we actually needed to log QubitRoute info. If we DID, it's a simple matter of flipping the value to true in the config file to re-enable it for debugging.

I would like to see us add Mike's patch to 2.3. Can we? I understand you guys had different approaches to this, and think it's time to revisit.

#17 Updated by Jesús García Crespo over 6 years ago

  • Assignee deleted (Jesús García Crespo)

#18 Updated by Nick Wilkinson about 6 years ago

  • Status changed from Feedback to In progress
  • Assignee set to Jesús García Crespo
  • Priority changed from Low to Medium

Hi Jesus, this dropped off the radar recently so I'm putting it back on the schedule.

#19 Updated by Nick Wilkinson about 6 years ago

  • Assignee changed from Jesús García Crespo to José Raddaoui Marín

#20 Updated by José Raddaoui Marín about 6 years ago

  • Status changed from In progress to QA/Review
  • Assignee changed from José Raddaoui Marín to Dan Gillean

I could not reproduce those warnings, but I've added Mike's patch to the qa/2.3.x branch.

#21 Updated by Dan Gillean about 6 years ago

  • File weird-blank-warning.png added
  • Status changed from QA/Review to Feedback
  • Assignee changed from Dan Gillean to Mike Gale

I don't know if this is the result of the patch, or something else, but at this point, even importing the example CSV templates from lib/task/import/example will give me a weird, empty warning (see attached image). The file imports, but a blank warning is kind of ominous! Can we figure out what's up with this?

#22 Updated by Jesús García Crespo about 6 years ago

  • Status changed from Feedback to QA/Review
  • Assignee changed from Mike Gale to Dan Gillean

#23 Updated by Dan Gillean almost 6 years ago

  • Status changed from QA/Review to Verified
  • Target version set to Release 2.3.0

Also available in: Atom PDF