Bug #7327
Reconsider calling save() in setActorByName()
| Status: | Verified | Start date: | 09/30/2014 | |
|---|---|---|---|---|
| Priority: | Medium | Due date: | ||
| Assignee: | Dan Gillean | % Done: | 100% | |
| Category: | I18N | |||
| Target version: | Release 2.2.0 | |||
| Google Code Legacy ID: | Tested version: | 2.1 | ||
| Sponsored: | No | Requires documentation: |
Description
Perhaps we should reconsidered saving inside helper functions for QubitInformationObject, it creates side effects that sometimes create unexpected results.
History
#1 Updated by Jesús García Crespo over 7 years ago
+1
#2 Updated by José Raddaoui Marín over 7 years ago
- Priority changed from Low to Medium
#3 Updated by José Raddaoui Marín over 7 years ago
- Status changed from New to Code Review
- Assignee changed from José Raddaoui Marín to Mike Gale
- % Done changed from 0 to 100
Created PR: 82
#4 Updated by Mike Gale over 7 years ago
- Status changed from Code Review to Feedback
- Assignee changed from Mike Gale to José Raddaoui Marín
Hi Radda,
I had a couple suggestions to the code. If you find my suggestions good, it looks good to me! Otherwise we can discuss further. Thanks for looking into this one!
#5 Updated by José Raddaoui Marín over 7 years ago
- Status changed from Feedback to Deploy
Thanks Mike!
I've added your suggestions and merged in qa/2.2.x
#6 Updated by José Raddaoui Marín over 7 years ago
- Status changed from Deploy to QA/Review
- Assignee changed from José Raddaoui Marín to Dan Gillean
Hi Dan, this can affect the same things mentioned in https://projects.artefactual.com/issues/7124#note-1
#7 Updated by Jesús García Crespo over 7 years ago
- Target version changed from Release 2.1.1 to Release 2.2.0
#8 Updated by Dan Gillean about 7 years ago
- Status changed from QA/Review to Verified