Bug #7716

Add new rights link broken during accession and information object creation

Added by Sarah Romkey over 7 years ago. Updated almost 7 years ago.

Status:VerifiedStart date:12/16/2014
Priority:HighDue date:
Assignee:Sarah Romkey% Done:

0%

Category:Accessions
Target version:Release 2.2.0
Google Code Legacy ID: Tested version:2.2
Sponsored:No Requires documentation:

Description

In qa 2.2, when you click on "Create new rights" in an accession record, you are redirected to right/edit.

Assigning to Mike G because this is likely related to PREMIS rights work.

History

#1 Updated by Sarah Romkey over 7 years ago

Making a note to myself on this ticket that we will need to update the screenshots in the 2.2 docs once we have a fix.

#2 Updated by Mike Gale over 7 years ago

  • Status changed from New to Feedback
  • Assignee changed from Mike Gale to Sarah Romkey

More details please. I could create accession rights when I tried, see: http://qa-22x.test.artefactual.com/2013-11-14-4

#3 Updated by Sarah Romkey over 7 years ago

Weird!

To reproduce:

- Add a new accession record, fill out whatever details you please

- Before hitting save, click on Rights area, then on Create New Rights

- Browser redirects to "right/edit."

#4 Updated by Sarah Romkey over 7 years ago

  • Assignee changed from Sarah Romkey to Mike Gale

#5 Updated by Mike Gale over 7 years ago

  • Status changed from Feedback to In progress

#6 Updated by Mike Gale over 7 years ago

  • Subject changed from Rights module in Accessions is broken to Add new rights link broken during accession and information object creation
  • Status changed from In progress to Feedback

Ah okay Sarah. The 'during accession creation screen' part was what I was missing. I've made some discoveries:

- This bug also applies when creating information objects

- The source of the bug is: before you click 'save' on initial accession creation, the accession hasn't been saved in AtoM and hence there's no accession slug/URL for the 'create new rights' link to refer to. How do you save rights to an accession that doesn't exist yet from a different page?

I see two possible solutions:

1. Move all the create rights forms into the rights section of the accession/info object creation pages. That way we can only try to add rights at the point in the save process after the accession or info object is created.
- Pros: Fixes the issue and lets users create rights during accession creation
- Cons: May take hours to refactor the code and move forms around, will make the rights section cluttered when editing/creating things (maybe we could use javascript to hide these forms until the user clicks 'create new rights'?)

2. If it's during a creation screen, simply grey out the 'create new rights' button and put a warning telling the user they need to save first before adding rights.
- Pros: Fixes the bug. Very fast to code.
- Cons: Feels kludgey, it seems the user should be able to add rights on accession/info object creation.

Sarah, I think I'll write an email to atom@ tomorrow explaining the things above, to get feedback from the team.

#7 Updated by David Juhasz over 7 years ago

Mike, the original design that I proposed to Andy when he did the PREMIS 2.2 upgrade was option #1 (I think) - the "Add rights" button is on the "view" page only. The ideas was to create a new description, save it, then add rights from the view page.

#8 Updated by Mike Gale over 7 years ago

  • Assignee changed from Mike Gale to Sarah Romkey

Hey Sarah,

I talked to David J and we're going to remove the add new rights / edit rights / delete rights from when the user is editing/creating archival descriptions and accessions. The user will need to perform these tasks when viewing and archival description / accession from now on. The impetus behind this is to cut down on clutter when editing archival descriptions.

David J said it is up to the archivists if we're going to keep the Rights section when editing descriptions (just read-only, so you can see existing rights in there), or if we should just remove the rights section in there altogether. Maybe you could confer with Dan on this?

thanks!

#9 Updated by Sarah Romkey over 7 years ago

  • Assignee changed from Sarah Romkey to Mike Gale

Hi Mike,

Understood!

I just discussed with Dan, and we agree that it would be fine to just remove the rights area from the edit templates. Our reasons are two fold:

1. The new rights form is really long- if someone decides to get really detailed, their description could time out and they would lose their work.

2. Adding rights is really a separate intellectual activity than creating a description. Rights information is also reflected in various ways through most descriptive standards; deciding that you wish to add PREMIS rights is a separate action.

So please, go ahead and remove the rights area from the descriptive templates. To make the user experience more consistent in the accession template, could we also remove it from there but add a button to the button bar for accessions to add PREMIS rights?

#10 Updated by Sarah Romkey over 7 years ago

  • Requires documentation set to Yes

#11 Updated by Sarah Romkey over 7 years ago

Regarding documentation, this will just require some editing and new screen shots in the 2.2 version of the docs. Currently it reflects both ways of getting at the PREMIS entry page.

#12 Updated by Mike Gale over 7 years ago

  • Status changed from Feedback to Code Review
  • Assignee changed from Mike Gale to José Raddaoui Marín

https://github.com/artefactual/atom/pull/94

Also note while doing this ticket I discovered another bug related to rights in accessions: #7742

#13 Updated by José Raddaoui Marín over 7 years ago

  • Status changed from Code Review to Feedback
  • Assignee changed from José Raddaoui Marín to Mike Gale

I've added some comments in the PR.

#14 Updated by Mike Gale over 7 years ago

  • Assignee changed from Mike Gale to José Raddaoui Marín

#15 Updated by José Raddaoui Marín over 7 years ago

  • Assignee changed from José Raddaoui Marín to Mike Gale

#16 Updated by Sarah Romkey over 7 years ago

Just giving this a bump so we remember to merge it :) Working on the documentation and testing but would like to use the most up to date code.

#17 Updated by Mike Gale about 7 years ago

  • Status changed from Feedback to QA/Review
  • Assignee changed from Mike Gale to Sarah Romkey

#18 Updated by Sarah Romkey about 7 years ago

  • Status changed from QA/Review to Verified

Verified- Rights area no longer appears while editing either accessions or archival descriptions, and is instead linked under "More" after the record has been saved.

#19 Updated by Sarah Romkey almost 7 years ago

  • Requires documentation deleted (Yes)

Also available in: Atom PDF