Bug #7757

Global search autocomplete links to all matching search results do not work for entities other than descriptions

Added by Dan Gillean over 5 years ago. Updated almost 3 years ago.

Status:VerifiedStart date:01/02/2015
Priority:MediumDue date:
Assignee:-% Done:

0%

Category:Search / Browse
Target version:Release 2.4.0
Google Code Legacy ID: Tested version:2.1.1, 2.2, 2.4
Sponsored:No Requires documentation:

Description

To reproduce

Type something that will cause multiple results to appear in each entity category (e.g. repositorires, actors, descriptions, etc) into the global search box. For example, start typing "Art" - and wait for the autocomplete result suggestions to appear in the search box drop-down

For actors, when more than 3 possible matches are listed, a link should appear that says "All matching People and Organizations" (or something similar depending on your settings). Click on this link.

Resulting error

User is redirected to Actor browse page. The search term is visible in the URL (example: http://qa-22x.test.artefactual.com/actor/browse?query=art&repos= ) but has no effect on the page. All results are shown, instead of those matching "art".

The search term appears in the global search box, and not in the dedicated Actor search box on the page.

Expected result

Search results are limited to those matching the search term. Search term appears in the dedicated actor search box, and NOT in the global search box any more (since pressing enter there would return archival description results).

Note that this is true for other entities as well.

I believe the relevant file is here: /apps/qubit/modules/search/templates/autocompleteSuccess.php

Related issues

Related to Access to Memory (AtoM) - Bug #8096: Typeahead search results aren't consistently clickable New 03/13/2015
Related to Access to Memory (AtoM) - Bug #10295: "all matching descriptions" link in global search autocom... Verified 09/12/2016
Related to Access to Memory (AtoM) - Bug #5720: Click "all matching ..." in the search box autocomplete l... New 09/30/2013

History

#1 Updated by Tim Hutchinson over 5 years ago

This one may be easy enough to fix, at least to make the behaviour for actors and repositories etc. consistent with descriptions (i.e. leaving aside the fuzzy search question which is documented in #5276).

The only issue seems to be that the target URL includes ?query= but it should be ?subquery=

#2 Updated by Dan Gillean over 5 years ago

  • Related to Bug #8096: Typeahead search results aren't consistently clickable added

#3 Updated by Jesús García Crespo over 4 years ago

  • Assignee deleted (Jesús García Crespo)

#4 Updated by Dan Gillean almost 4 years ago

  • Related to Bug #10295: "all matching descriptions" link in global search autocomplete drop-down will display JSON added

#5 Updated by Dan Gillean almost 4 years ago

  • Related to Bug #5720: Click "all matching ..." in the search box autocomplete list leads to a browse page without the same results added

#6 Updated by Dan Gillean over 3 years ago

  • Tested version 2.4 added

Reproduced in qa/2.4.x on 2016-12-23

#7 Updated by Dan Gillean almost 3 years ago

This remains an issue, though it appears as if it was fixed for a time. Testing in the 2.4 development branch (2017-07).

Examples

Choosing "All matching people and organizations" when searching for John:

Choosing "All matching places" when searching for city:

Choosing "All matching subjects when searching for test:

Choosing "All matching institutions" when searching for test:

#8 Updated by Nick Wilkinson almost 3 years ago

  • Assignee set to José Raddaoui Marín
  • Target version set to Release 2.4.0

Hi Radda, can you provide a quick estimate for this?

#9 Updated by José Raddaoui Marín almost 3 years ago

  • Assignee changed from José Raddaoui Marín to Nick Wilkinson

Hi Nick, between 2-4 hours should be enough.

One thing that I've noticed is that the institution and actor links are trying to show the matching records, but the subjects and places don't do that, they are just links to "all subjects" and "all places". This could be changed in those hours too, to match the other links.

#10 Updated by Nick Wilkinson almost 3 years ago

  • Assignee changed from Nick Wilkinson to José Raddaoui Marín

Thanks Radda, please go ahead with the changes you propose.

#11 Updated by José Raddaoui Marín almost 3 years ago

  • Status changed from New to Code Review
  • Assignee changed from José Raddaoui Marín to Nick Wilkinson

We'll still have the problem where the results are not exactly the same in the browse pages, due to how the queries are made in the autocomplete and the browse pages, but this should fix the links.

PR 767

#12 Updated by Nick Wilkinson almost 3 years ago

  • Assignee changed from Nick Wilkinson to Steve Breker

#13 Updated by Steve Breker almost 3 years ago

  • Status changed from Code Review to Feedback
  • Assignee changed from Steve Breker to José Raddaoui Marín

CR looks good.

#14 Updated by José Raddaoui Marín almost 3 years ago

  • Status changed from Feedback to QA/Review
  • Assignee changed from José Raddaoui Marín to Dan Gillean

Merged in qa/2.4.x

#15 Updated by Dan Gillean almost 3 years ago

  • Status changed from QA/Review to Verified
  • Assignee deleted (Dan Gillean)

Looks great!

Also available in: Atom PDF