Bug #7818

An apostrophe in the authorized form of name will break edit page javascript for an authority record

Added by Dan Gillean over 7 years ago. Updated over 7 years ago.

Status:VerifiedStart date:01/14/2015
Priority:MediumDue date:
Assignee:Dan Gillean% Done:

0%

Category:Actor
Target version:Release 2.1.2
Google Code Legacy ID: Tested version:2.1, 2.1.1
Sponsored:No Requires documentation:

Description

To reproduce
  • Navigate to an existing authority record (with no apostrophe in the title)
  • enter edit mode - note how the page looks
  • Add an apostrophe to the Authorized form of name
  • Save
  • Re-enter edit mode, and compare how the edit page now looks

Error encountered
Javascript on edit page no longer works as expected (tooltips are visible, etc). See attached screenshot.
A user has reported the following:

Seems to be caused by an unescaped javascript variable, here:

https://github.com/artefactual/atom/blob/stable/2.1.x/plugins/sfIsaarPlugin/modules/sfIsaarPlugin/templates/_relatedAuthorityRecord.php#L124

Expected result
Edit page loads properly; is not affected by the apostrophe or any other unescaped character.

edit-page-apostrophe.png (78.7 KB) Dan Gillean, 01/14/2015 02:11 PM

History

#2 Updated by Dan Gillean over 7 years ago

  • Target version changed from Release 2.2.0 to Release 2.1.2

Going to try to get this fix into the 2.1.2 translation release we will be preparing on Feb 9th. More details in this user forum post: https://groups.google.com/d/msg/ica-atom-users/vlnl21EQvOo/ApTpgWg1XSsJ

#3 Updated by Jesús García Crespo over 7 years ago

  • Status changed from New to QA/Review
  • Assignee changed from Jesús García Crespo to Dan Gillean

#4 Updated by Dan Gillean over 7 years ago

  • Status changed from QA/Review to Verified

Also available in: Atom PDF