Bug #7883

Comment in EAD XML are not excluded during import

Added by Dan Gillean over 7 years ago. Updated almost 7 years ago.

Status:VerifiedStart date:01/26/2015
Priority:MediumDue date:
Assignee:Dan Gillean% Done:

0%

Category:EAD
Target version:Release 2.2.0
Google Code Legacy ID: Tested version:2.1, 2.1.1, 2.2
Sponsored:No Requires documentation:

Description

To reproduce
  • Create a new EAD XML file with comments throughout, or use the attached (provided via user forum1)
  • Attempt to import the EAD file

Resulting error
Comments appear in import data

Expected result
Valid XML comments do not import as data

[1] User forum post: https://groups.google.com/d/msg/ica-atom-users/7aqkTMQRdgw/Xj4-lZW356IJ

MS093-Kastenbaum-TARO00009.xml Magnifier - User-provided EAD sample (25.2 KB) Dan Gillean, 01/26/2015 03:25 PM

History

#1 Updated by Mike Gale over 7 years ago

I think this is because we don't handle XML comments at all in our code. If we added a check somewhere around here and checked for node type comment like described here

I think we could fix this.

#2 Updated by Dan Gillean over 7 years ago

  • Assignee changed from Mike Cantelon to Mike Gale

#3 Updated by Mike Gale about 7 years ago

  • Status changed from New to Code Review
  • Assignee changed from Mike Gale to Mike Cantelon

#4 Updated by Mike Cantelon almost 7 years ago

  • Status changed from Code Review to Feedback
  • Assignee changed from Mike Cantelon to Mike Gale

Looks good to me! Very cool!

#5 Updated by Mike Gale almost 7 years ago

  • Status changed from Feedback to QA/Review
  • Assignee changed from Mike Gale to Dan Gillean

merged into qa/2.2.x

#6 Updated by Dan Gillean almost 7 years ago

  • Status changed from QA/Review to Verified

Awesome! Thanks!

Also available in: Atom PDF