Feature #7948

Use general label for personal or corporate history when entity type not set

Added by David Juhasz over 7 years ago. Updated about 7 years ago.

Status:VerifiedStart date:02/09/2015
Priority:MediumDue date:
Assignee:Sarah Romkey% Done:

0%

Category:Standards compliance
Target version:Release 2.2.0
Google Code Legacy ID: Tested version:
Sponsored:No Requires documentation:

Description

Use a generic field label when the entity type is not set for a related authority record (creator, accumulator, etc.)

The desired labels by descriptive template in AtoM are:
  • ISAD-G:
    • 3.2.2 Administrative / Biographical history
  • RAD:
    • 1.7B Administrative history/Biographical sketch
  • DACS:
    • 2.7 Administrative/Biographical History
  • Dublin Core:
    • Not applicable
  • MODS:
    • Not applicable

History

#2 Updated by David Juhasz over 7 years ago

  • Status changed from New to In progress

#3 Updated by David Juhasz over 7 years ago

  • Status changed from In progress to Code Review
  • Assignee changed from David Juhasz to Jesús García Crespo

PR:108

#4 Updated by Jesús García Crespo over 7 years ago

  • Status changed from Code Review to Feedback
  • Assignee changed from Jesús García Crespo to David Juhasz

LGTM! Please squash the three commits into one when you are merging:
$ git checkout qa/2.2.x; git merge --squash yourremote/dev/issue-7948-generic-history-label

BTW, I don't think you need to use your own remote as you have write access to dev/* in :atom.git after all, i.e. you can create pull requests between two branches even if they belong to the same repo in GitHub.

#5 Updated by David Juhasz over 7 years ago

  • Status changed from Feedback to Code Review
  • Assignee changed from David Juhasz to Jesús García Crespo

Jesús I've updated the code to handle unexpected entityTypeId's. Please have a look at PR:108

#6 Updated by David Juhasz over 7 years ago

Oh, and thanks for the note about using the official atom repo, good to know!

#7 Updated by Jesús García Crespo over 7 years ago

  • Status changed from Code Review to Feedback
  • Assignee changed from Jesús García Crespo to David Juhasz

Perfect. Two observations but I'm not sure if it's worth attention, we use null instead of NULL and no semicolons in templates unless it's necessary. Not a big deal, feel free to ignore.

#8 Updated by David Juhasz about 7 years ago

  • Status changed from Feedback to Code Review
  • Assignee changed from David Juhasz to Jesús García Crespo

I made those two changes Jesús. Please review.

#9 Updated by Jesús García Crespo about 7 years ago

  • Status changed from Code Review to Feedback
  • Assignee changed from Jesús García Crespo to David Juhasz

Discussed this with David over the chat. He accidentally added a commit merge (2ce4e0d3422f02ee079bf83a12dedefbb225fc72). He is going to remove it with rebase -i, then fetch && rebase origin/qa/2.2.x, then final merge --squash from qa/2.2.x.

#10 Updated by David Juhasz about 7 years ago

  • Status changed from Feedback to QA/Review
  • Assignee changed from David Juhasz to Sarah Romkey

#11 Updated by Sarah Romkey about 7 years ago

Looking good in ISAD and DACS, but will need to wait for #8032 to be fixed to QA in RAD.

#12 Updated by Dan Gillean about 7 years ago

  • Status changed from QA/Review to Verified

Works in RAD too :D

Also available in: Atom PDF