Bug #8135

Top-level description filter interferes with Treeview quicksearch when viewing all results

Added by Dan Gillean about 7 years ago. Updated about 7 years ago.

Status:VerifiedStart date:03/25/2015
Priority:MediumDue date:
Assignee:Dan Gillean% Done:

0%

Category:Search / Browse
Target version:Release 2.2.0
Google Code Legacy ID: Tested version:2.1.1, 2.2
Sponsored:No Requires documentation:No

Description

To reproduce
  • Navigate to a description with children
  • Perform a search using the treeview's quick-search tab
  • Select the "Browse all descriptions" option
Error encountered
  • Top-level description filter is engaged
  • No results are shown
Expected result
  • Lower-level descriptions are shown. The top-level description filter is not engaged.

Notes
Reported by Zac H of CNSA. He has submitted a PR here: https://github.com/artefactual/atom/pull/128

There is also a video of the bug here: https://www.youtube.com/watch?v=4R5-v4hEN7Q

The top-level description filter was added in issue #7570. Right now in AtoM there is a discrepancy between the search and browse pages - ultimately they should be one template used in different ways, but instead we are maintaining two nearly identical pages, one for browse and one for search. This is described in issue #6015. It appears that clicking the treeview's "Browse all descriptions" options will take a user to a browse page (rather than a search page), where the new top-level filter is engaged by default, rather than a search page, where it is not engaged by default. This fix will add a parameter to the query to turn the top-level filter off.

History

#1 Updated by Jesús García Crespo about 7 years ago

  • Status changed from Code Review to QA/Review
  • Assignee changed from Jesús García Crespo to Dan Gillean

Merged, see aee1d19.

#2 Updated by Dan Gillean about 7 years ago

  • Status changed from QA/Review to Verified

Works like a charm :)

Also available in: Atom PDF