Bug #8236

Stop using readline

Added by Jesús García Crespo about 7 years ago. Updated about 7 years ago.

Status:VerifiedStart date:04/07/2015
Priority:HighDue date:
Assignee:Dan Gillean% Done:

0%

Category:CLI toolsEstimated time:2.00 hours
Target version:Release 2.2.0
Google Code Legacy ID: Tested version:2.0.0, 2.0.1, 2.1, 2.1.1
Sponsored:No Requires documentation:

Description

readline is not available in Windows environments and some Linux distributions don't include it.

- Use cross-platform alternative: see comments in http://php.net/manual/en/ref.readline.php
- Remove dependency from the requirements

Related user discussion: https://groups.google.com/d/msg/ica-atom-users/cR_NPM5EAeU/gnRlcK1ZTpQJ

History

#1 Updated by Jesús García Crespo about 7 years ago

  • Subject changed from Use readline only if available to Stop using readline

#2 Updated by Jesús García Crespo about 7 years ago

  • Status changed from New to Code Review
  • Assignee changed from Jesús García Crespo to José Raddaoui Marín

#4 Updated by José Raddaoui Marín about 7 years ago

  • Status changed from Code Review to In progress
  • Assignee changed from José Raddaoui Marín to Jesús García Crespo

#5 Updated by Jesús García Crespo about 7 years ago

  • Status changed from In progress to QA/Review
  • Assignee changed from Jesús García Crespo to Dan Gillean
  1. Remove php5-readline from the system by running "sudo apt-get purge php5-readline"
  2. Verify that the following task works:
    • symfony jobs:clear
    • symfony tools:delete-drafts
    • symfony tools:add-superuser
    • symfony tools:upgrade-sql
    • symfony tools:purge

#6 Updated by Dan Gillean about 7 years ago

  • Status changed from QA/Review to Verified

All tasks worked after uninstalling readline.

Also available in: Atom PDF