Bug #8512

Dominion javascript error, 'top' undefined

Added by Mike Gale almost 7 years ago. Updated almost 7 years ago.

Status:VerifiedStart date:06/03/2015
Priority:LowDue date:
Assignee:José Raddaoui Marín% Done:

0%

Category:Theming
Target version:Release 2.2.0
Google Code Legacy ID: Tested version:
Sponsored:No Requires documentation:

Description

When inspecting a page in Chromium dev tools, we constantly get this JS error when loading archival description pages (and pretty much doing anything):

Uncaught TypeError: Cannot read property 'top' of undefined (dominion.js:843)

History

#1 Updated by Mike Gale almost 7 years ago

Note: this isn't actually breaking any functionality in AtoM as far as I can tell, and is more of a warning, but we should still fix it.

#2 Updated by José Raddaoui Marín almost 7 years ago

That's my fault. We should check that the element exists after:

https://github.com/artefactual/atom/blob/qa/2.2.x/js/dominion.js#L779

#3 Updated by José Raddaoui Marín almost 7 years ago

  • Status changed from New to Code Review
  • Target version changed from Release 2.3.0 to Release 2.2.0

Hi Mike, I think we should include this in 2.2, I've created PR 191

#4 Updated by Mike Gale almost 7 years ago

  • Assignee changed from Mike Gale to José Raddaoui Marín

looks good

#5 Updated by José Raddaoui Marín almost 7 years ago

  • Status changed from Code Review to QA/Review
  • Assignee changed from José Raddaoui Marín to Mike Gale

Merged! Mike, could you test it?

#6 Updated by Mike Gale almost 7 years ago

  • Status changed from QA/Review to Verified
  • Assignee changed from Mike Gale to José Raddaoui Marín

I just tested it, the warning no longer appears for me.

Also available in: Atom PDF