Bug #8537

Fix empty() calls for PHP < 5.5

Added by José Raddaoui Marín almost 7 years ago. Updated almost 6 years ago.

Status:VerifiedStart date:06/10/2015
Priority:MediumDue date:
Assignee:José Raddaoui Marín% Done:

0%

Category:Internals
Target version:Release 2.3.0
Google Code Legacy ID: Tested version:
Sponsored:No Requires documentation:

Description

Prior to PHP 5.5, empty() only supports variables:

http://php.net/manual/en/function.empty.php

History

#1 Updated by José Raddaoui Marín almost 7 years ago

  • Status changed from New to Code Review
  • Assignee changed from José Raddaoui Marín to Mike Gale

#2 Updated by Mike Gale almost 7 years ago

  • Assignee changed from Mike Gale to José Raddaoui Marín

Looks good. We have a coding guidelines wiki page somewhere (I lost the URL, haha) that warns against empty() as well, for what it's worth. I know there's a lot of empty() calls anyway throughout AtoM though.

#3 Updated by Dan Gillean almost 7 years ago

New coding standard page in wiki: https://wiki.accesstomemory.org/Development/Coding_standard

Devs, please look at this page and update it as necessary! It's copied over from the old Qubit Toolkit wiki, but it could use a refresh.

#4 Updated by José Raddaoui Marín almost 7 years ago

  • Status changed from Code Review to Verified

I think I'm the only one working with PHP < 5.5 ...

#5 Updated by Dan Gillean almost 6 years ago

  • Category set to Internals

Also available in: Atom PDF