Bug #8598

tools:upgrade-sql failing on multiple client SQL dumps

Added by Mike Gale almost 7 years ago. Updated about 6 years ago.

Status:VerifiedStart date:06/24/2015
Priority:HighDue date:
Assignee:-% Done:

0%

Category:CLI tools
Target version:Release 2.3.0
Google Code Legacy ID: Tested version:2.3
Sponsored:No Requires documentation:

Description

Multiple client SQL files I tried to upgrade to 2.3 give the following error:

Column already exists: 1060 Duplicate column name 'download_path'

I think we should check for the column's existence too before creating it. I'm not sure why so many clients already had that column or whatever, they were using 2.1 I believe...

arMigration0130.class.php is the culprit. Maybe we can do something like so: http://stackoverflow.com/a/3242110

History

#1 Updated by Jesús García Crespo about 6 years ago

  • Priority changed from Medium to High

#2 Updated by Mike Cantelon about 6 years ago

  • Status changed from New to Code Review
  • Assignee changed from Mike Cantelon to Nick Wilkinson

#3 Updated by Jesús García Crespo about 6 years ago

  • Assignee changed from Nick Wilkinson to Mike Gale

#4 Updated by Mike Gale about 6 years ago

  • Assignee changed from Mike Gale to Mike Cantelon

That's indeed weird how only certain migrations give us problems. Somehow the tables / columns get into client database schemas before we create proper migrations for them? Or somehow their db versions get out of wack? At any rate, this extra check looks good to me.

#5 Updated by Mike Cantelon about 6 years ago

  • Status changed from Code Review to QA/Review
  • Assignee changed from Mike Cantelon to Nick Wilkinson

Merged and ready for QA.

#6 Updated by Nick Wilkinson about 6 years ago

  • Status changed from QA/Review to Verified
  • Assignee deleted (Nick Wilkinson)

Also available in: Atom PDF