Task #8641

Remove fetching existing actors by repository

Added by Mike Gale almost 7 years ago. Updated almost 7 years ago.

Status:VerifiedStart date:07/03/2015
Priority:MediumDue date:
Assignee:Dan Gillean% Done:

0%

Category:Import/Export
Target version:Release 2.2.0
Google Code Legacy ID: Tested version:2.2, 2.3
Sponsored:No Requires documentation:

Description

Remove getByNameAndRepositoryId calls and just create actors on import, as the mentioned function has severe performance issues in some cases.


Related issues

Related to Access to Memory (AtoM) - Feature #8642: Add relation rows to associate actors with repositories Verified 07/03/2015
Related to Access to Memory (AtoM) - Task #10506: Improve actor matching on descriptions import Verified 11/02/2016

History

#1 Updated by Mike Gale almost 7 years ago

  • Related to Feature #8642: Add relation rows to associate actors with repositories added

#2 Updated by Mike Gale almost 7 years ago

  • Status changed from New to Code Review
  • Assignee changed from Mike Gale to José Raddaoui Marín

#3 Updated by José Raddaoui Marín almost 7 years ago

  • Status changed from Code Review to Feedback
  • Assignee changed from José Raddaoui Marín to Mike Gale

Hi Mike, I think we were checking for existing actors by name without the repository condition before, and after this fix we are never going to check that, it will always create a new actor even if there is one with the same name. Not sure if that's the intended behaviour or if we wan't to check only by name before creating a new actor. I think you should check that with Dan.

If we're not going to match actors by the name it looks good to me.

#4 Updated by Mike Gale almost 7 years ago

  • Status changed from Feedback to In progress

I talked it over with Dan and he agrees with Radda:

"link on exact match of name, but DON'T overwrite / update
if possible
it's better to lose the bioghist you are trying to import, which you obvs have locally, than to overwrite the old one accidentally"

I will rework the solution to do this.

#5 Updated by Mike Gale almost 7 years ago

  • Status changed from In progress to Code Review
  • Assignee changed from Mike Gale to José Raddaoui Marín

Hi Radda, please see the latest commit in that pull request. I think it should now do what you and Dan suggested. I tested it for importing CSVs and EAD and it seems to work as intended, but Dan will need to test the METS parser thing, since I have no idea where that feature is :)

#6 Updated by José Raddaoui Marín almost 7 years ago

  • Status changed from Code Review to Feedback
  • Assignee changed from José Raddaoui Marín to Mike Gale

It looks great!

#7 Updated by Mike Gale almost 7 years ago

  • Status changed from Feedback to QA/Review
  • Assignee changed from Mike Gale to Dan Gillean

#8 Updated by Dan Gillean almost 7 years ago

  • Status changed from QA/Review to Verified

#9 Updated by José Raddaoui Marín over 5 years ago

  • Related to Task #10506: Improve actor matching on descriptions import added

Also available in: Atom PDF