Remove fetching existing actors by repository
|Assignee:||Dan Gillean||% Done:|
|Target version:||Release 2.2.0|
|Google Code Legacy ID:||Tested version:||2.2, 2.3|
Remove getByNameAndRepositoryId calls and just create actors on import, as the mentioned function has severe performance issues in some cases.
#3 Updated by José Raddaoui Marín almost 7 years ago
- Status changed from Code Review to Feedback
- Assignee changed from José Raddaoui Marín to Mike Gale
Hi Mike, I think we were checking for existing actors by name without the repository condition before, and after this fix we are never going to check that, it will always create a new actor even if there is one with the same name. Not sure if that's the intended behaviour or if we wan't to check only by name before creating a new actor. I think you should check that with Dan.
If we're not going to match actors by the name it looks good to me.
#4 Updated by Mike Gale almost 7 years ago
- Status changed from Feedback to In progress
I talked it over with Dan and he agrees with Radda:
"link on exact match of name, but DON'T overwrite / update
it's better to lose the bioghist you are trying to import, which you obvs have locally, than to overwrite the old one accidentally"
I will rework the solution to do this.
#5 Updated by Mike Gale almost 7 years ago
- Status changed from In progress to Code Review
- Assignee changed from Mike Gale to José Raddaoui Marín
Hi Radda, please see the latest commit in that pull request. I think it should now do what you and Dan suggested. I tested it for importing CSVs and EAD and it seems to work as intended, but Dan will need to test the METS parser thing, since I have no idea where that feature is :)