Bug #8646

Duplication skipping in CSV import still runs row processing logic

Added by Mike Cantelon almost 7 years ago. Updated about 2 years ago.

Status:VerifiedStart date:07/06/2015
Priority:MediumDue date:
Assignee:Sara Allain% Done:

0%

Category:CSV import
Target version:Release 2.3.0
Google Code Legacy ID: Tested version:
Sponsored:No Requires documentation:

History

#1 Updated by Mike Cantelon almost 7 years ago

  • Status changed from In progress to Code Review
  • Assignee changed from Mike Cantelon to Nick Wilkinson

I've made a PR that addresses this issue and also adds an "--update" mode that can be used to replace a description's digital objects.

https://github.com/artefactual/atom/pull/201

#2 Updated by Nick Wilkinson almost 7 years ago

  • Assignee changed from Nick Wilkinson to Mike Gale

Hi Mike, can you please take a look at this for Code Review?

#3 Updated by Mike Gale almost 7 years ago

  • Status changed from Code Review to Feedback
  • Assignee changed from Mike Gale to Mike Cantelon

Looks good to me. I just had one minor comment on github about style.

#4 Updated by Mike Cantelon almost 7 years ago

  • Status changed from Feedback to QA/Review
  • Assignee changed from Mike Cantelon to Dan Gillean
  • Requires documentation set to Yes

Hi Dan. We can talk about this, for your QA review, when you get back.

#5 Updated by Sara Allain about 6 years ago

  • Assignee changed from Dan Gillean to Mike Cantelon

Mike - can you let me know how to test this?

#6 Updated by Jesús García Crespo about 6 years ago

  • Status changed from QA/Review to Feedback
  • Assignee changed from Mike Cantelon to Sara Allain

#7 Updated by Jesús García Crespo about 6 years ago

  • Assignee changed from Sara Allain to Mike Cantelon

#8 Updated by Mike Cantelon about 6 years ago

  • Status changed from Feedback to QA/Review
  • Assignee changed from Mike Cantelon to Sara Allain

How to test:

1) Create test description and give it a subject access point

2) Export as CSV

3) Attempt to import CSV file

The fixed result is the importer will detect the import data as duplicate data and a duplicate subject access point won't be duplicated.

#9 Updated by Sara Allain about 6 years ago

  • Status changed from QA/Review to Verified

Looks good!

#10 Updated by Dan Gillean about 2 years ago

  • Requires documentation deleted (Yes)

Also available in: Atom PDF