Feature #8647

Update FITS script to use a named pipe instead of stdout

Added by Misty De Meo almost 7 years ago. Updated almost 5 years ago.

Status:QA/ReviewStart date:07/06/2015
Priority:MediumDue date:
Assignee:-% Done:

0%

Category:FITS
Target version:Release 1.7.0
Google Code Legacy ID: Pull Request:https://github.com/artefactual/archivematica-fpr-tools/pull/5/
Sponsored:No Requires documentation:

Description

The current FITS script captures all data written by FITS to stdout. However, as seen in issues like #8610, FITS has a bug in which it will sometimes print debugging information to stdout, producing invalid and unparseable XML.

Instead of writing to stdout, FITS's output switch accepts file-like objects - we could specify a named pipe created via mkfifo to ensure that the output can't be polluted.

History

#1 Updated by Misty De Meo over 6 years ago

We didn't have luck with the named pipe approach; however, saving the file to a temporary location on disk and catting that to stdout will work.

#2 Updated by Sarah Romkey about 6 years ago

  • Target version deleted (Release 1.5.0)

#3 Updated by Justin Simpson over 5 years ago

  • Assignee deleted (Misty De Meo)
  • Priority changed from Medium to Low

#4 Updated by Holly Becker over 5 years ago

  • Pull Request set to https://github.com/artefactual/archivematica-fpr-tools/pull/5/

#5 Updated by Sarah Romkey over 5 years ago

  • Target version set to Release 1.7.0

#6 Updated by Justin Simpson over 5 years ago

  • Status changed from New to Code Review

#7 Updated by Joel Dunham about 5 years ago

  • Assignee set to Jesús García Crespo
  • Priority changed from Low to Medium

- AM-fpr-admin PR: https://github.com/artefactual/archivematica-fpr-admin/pull/48
- AM PR: https://github.com/artefactual/archivematica/pull/608

Jesus, I ended up following Justin's method when he updated Siegfried. I kept the original command, but I'm editing fpr/migrations/initial_data.json. Don't know if that's ideal...

#8 Updated by Jesús García Crespo about 5 years ago

  • Status changed from Code Review to Feedback
  • Assignee changed from Jesús García Crespo to Joel Dunham

Users upgrading AM will never see the change if you do it that way. I think we really need a proper migration?

#9 Updated by Joel Dunham almost 5 years ago

  • Assignee changed from Joel Dunham to Nick Wilkinson

#10 Updated by Nick Wilkinson almost 5 years ago

  • Assignee changed from Nick Wilkinson to José Raddaoui Marín

Hi Radda, assigning to you for CR.

#11 Updated by José Raddaoui Marín almost 5 years ago

  • Status changed from Feedback to Code Review
  • Assignee changed from José Raddaoui Marín to Nick Wilkinson

It looks to me, but I don't know a lot about migrations yet. It's probably better if Jesus can double check.

#12 Updated by Nick Wilkinson almost 5 years ago

  • Assignee changed from Nick Wilkinson to Jesús García Crespo

#13 Updated by Jesús García Crespo almost 5 years ago

  • Status changed from Code Review to QA/Review
  • Assignee changed from Jesús García Crespo to Nick Wilkinson

LGTM

#14 Updated by Nick Wilkinson almost 5 years ago

  • Assignee deleted (Nick Wilkinson)

Also available in: Atom PDF