Bug #8675

XML-FO generated by AtoM only works with Apache FOP 1.0

Added by Mike Gale almost 7 years ago. Updated about 6 years ago.

Status:VerifiedStart date:07/10/2015
Priority:MediumDue date:
Assignee:Jesús García Crespo% Done:

0%

Category:Import/Export
Target version:Release 2.3.0
Google Code Legacy ID: Tested version:
Sponsored:No Requires documentation:

Description

I just noticed Apache FOP 2.0 was out. We're currently instructing users to use FOP 1.0 because 1.1 had a bug that was crashing our AtoM worker when generating PDFs in certain cases. However, I tried a sample file that crashed way back in the day and it seems to work fine in 2.0.

History

#1 Updated by Jesús García Crespo over 6 years ago

  • Tracker changed from Task to Bug
  • Subject changed from Test out FOP 2.0 and update documentation if OK to XML-FO generated by AtoM only works with Apache FOP 1.0
  • Category set to Import/Export
  • Target version set to Release 2.3.0

I've confirmed that the problem persists in Apache FOP 2.1.

Possible workaround, replace the empty <fo:table-body/> element with:

               <fo:table-body>
                  <fo:table-row>
                     <fo:table-cell>
                        <fo:block>...</fo:block>
                     </fo:table-cell>
                  </fo:table-row>
               </fo:table-body>

Can we make these changes in our XSL files? See https://github.com/artefactual/atom/tree/HEAD/lib/task/pdf.

#2 Updated by Jesús García Crespo over 6 years ago

We filed a but at FOP's Jira tracker: https://issues.apache.org/jira/browse/FOP-2403

The stack trace: http://pastebin.com/SyHH2pnk

#3 Updated by Jesús García Crespo over 6 years ago

Once it's fixed we gotta remember to update our ansible role (https://github.com/artefactual-labs/ansible-atom) and website docs accordingly.

#4 Updated by Mike Gale about 6 years ago

2.1 still throws an exception. Adding fo:block sub-elements to the problematic part of the XSL seemed to fix the exception issue, but was yielding a blank PDF then when it shouldn't be. It'll take some further investigation to figure out what's going on.

#5 Updated by Jesús García Crespo about 6 years ago

  • Status changed from New to Code Review

#6 Updated by Jesús García Crespo about 6 years ago

Dan, you'll have to install FOP 2.1 to verify this. Just follow the instructions on the docs replacing "1.0" with "2.1".
Please reassign to me (and ping me?) when you are done and I'll update the docs and our Ansible role.

#7 Updated by Mike Gale about 6 years ago

  • Assignee changed from Mike Gale to Jesús García Crespo

I think it's fine, but I suspect there are other issues that will come up from upgrading to 2.1. I've seen a couple that only occur when very specific EAD is fed to it.

I guess we can address those issues when we encounter them.

#8 Updated by Jesús García Crespo about 6 years ago

  • Status changed from Code Review to QA/Review
  • Assignee changed from Jesús García Crespo to Dan Gillean

Merged.

#9 Updated by Dan Gillean about 6 years ago

  • Status changed from QA/Review to Verified
  • Assignee changed from Dan Gillean to Jesús García Crespo

I've now upgraded 2 different VMs from 1.0 to 2.1 and been successful in generating finding aids. Jesus, I know you've updated the installation docs already - is there still work to do with the Ansible roles?

#10 Updated by Jesús García Crespo about 6 years ago

The Ansible role was already upgraded!

Also available in: Atom PDF