Bug #8784
Schema and models are out of sync
Status: | Verified | Start date: | 08/06/2015 | |
---|---|---|---|---|
Priority: | Critical | Due date: | ||
Assignee: | Dan Gillean | % Done: | 0% | |
Category: | Data model / ORM | |||
Target version: | Release 2.2.1 | |||
Google Code Legacy ID: | Tested version: | |||
Sponsored: | No | Requires documentation: |
Description
In qa/2.3.x digital_object.lft and digital_object.rgt were not completely removedIn qa/2.3.x granted_right was missing in schema.yml and some properties did not make it into the models- Changes in event table (information_object_id col was replaced with object_id) are not fully integrated in the models (see https://github.com/artefactual/atom/pull/106 for more details) - in qa/2.3.x this is what you get in BaseInformationObject after running prople:build-model: https://gist.github.com/sevein/f8d82ea43a2fce37dc0b - there are multiple places in the application where we relied on ->events, should we be using ->eventsRelatedByobjectId instead? A possible workaround was documented in the mailing list to one of our users: https://groups.google.com/d/msg/ica-atom-users/QIxBmWNtNLE/AD6EEU99BAAJ
Related issues
History
#1 Updated by Dan Gillean almost 7 years ago
- Target version changed from Release 2.2.0 to Release 2.2.1
#2 Updated by Jesús García Crespo almost 7 years ago
- Target version changed from Release 2.2.1 to Release 2.3.0
#3 Updated by Jesús García Crespo almost 7 years ago
- Subject changed from granted_right is missing in schema.yml to Schema and models are out of sync
- Description updated (diff)
- Assignee deleted (
Jesús García Crespo) - Priority changed from High to Critical
#4 Updated by Jesús García Crespo almost 7 years ago
- Status changed from New to QA/Review
- Assignee set to Mike Gale
Solution for #1 and #2 here: https://github.com/artefactual/atom/commit/e29034cd0c6d267a14a7aa8a7888b04d51cf2128
#5 Updated by Jesús García Crespo almost 7 years ago
- Status changed from QA/Review to Code Review
#6 Updated by Jesús García Crespo almost 7 years ago
- Status changed from Code Review to New
- Assignee deleted (
Mike Gale)
Our solutions for 1) and 2) have been included in qa/2.3.x, we haven't addressed 3) yet.
Feel free to reuse dev/issue-8784-modelschema-sync. This is the output of git diff after running propel:build-model: https://gist.github.com/sevein/f8d82ea43a2fce37dc0b.
#7 Updated by Jesús García Crespo almost 7 years ago
- Description updated (diff)
#8 Updated by Jesús García Crespo over 6 years ago
- Description updated (diff)
#9 Updated by Jesús García Crespo over 6 years ago
- Description updated (diff)
- Assignee set to Mike Cantelon
#10 Updated by José Raddaoui Marín over 6 years ago
- Assignee changed from Mike Cantelon to José Raddaoui Marín
#11 Updated by José Raddaoui Marín over 6 years ago
- Status changed from New to Code Review
- Assignee changed from José Raddaoui Marín to Nick Wilkinson
Ready for code review: PR 250
#12 Updated by Nick Wilkinson over 6 years ago
- Assignee changed from Nick Wilkinson to Jesús García Crespo
#13 Updated by David Juhasz over 6 years ago
- Blocks Bug #9102: Fix rights duplication in arInheritRightsJob added
#14 Updated by Jesús García Crespo over 6 years ago
- Status changed from Code Review to Feedback
- Assignee changed from Jesús García Crespo to José Raddaoui Marín
Nice, Radda. I'm surprised this only took you five hours. I think next it'd be nice to identify the different parts of the application affected by this commit, prepare a list and send it to Dan. We need to verify that this is not introducing new bugs.
#15 Updated by José Raddaoui Marín over 6 years ago
- Status changed from Feedback to QA/Review
- Assignee changed from José Raddaoui Marín to Dan Gillean
Hi Dan,
This should affect all the places where we work with events, the ones I found and fixed are the following:
- Add, edit and delete event in the information object edit pages. In all templates
- View events in the information objects index pages. In all templates
- Delete repositories with events associated (not sure how the events are added to the repos, but the delete code is there)
- Delete a term that is used as event type in any event
- DIP upload with creator in dmdSec section Dublin Core data
- CSV export
- Add, edit and delete event in the accession edit page
- Create information object from accession with events
Other import/export cases use the same functions used when the events are managed in the information object edit and index pages.
I may have missed something else, if you think on any other place that uses events, please test it as well.
#17 Updated by José Raddaoui Marín over 6 years ago
It looks like the event changes were introduced in 2.2. I'll add the fix to stable/2.2.x too when it gets verified in qa/2.3.x
#18 Updated by Dan Gillean over 6 years ago
- Status changed from QA/Review to Verified
Ok,
I haven't tested DIP upload cuz I don't have a set-up for that. If we think that is important, maybe I can pass this to Sarah, or someone on the AM team.
Otherwise, I have tried to test all of the behaviors described above, and some more. I did not encounter any issues. LGTM!
#19 Updated by David Juhasz over 6 years ago
I cherry-picked the fix to stable/2.2.x: https://github.com/artefactual/atom/commit/b038f6ab3905153425065e1f4d0d0724eebdb475
#20 Updated by David Juhasz over 6 years ago
- Target version changed from Release 2.3.0 to Release 2.2.1