Bug #8840
Improve top-level descriptions/all descriptions radio button behavior when limiting results on a search
| Status: | Verified | Start date: | 08/21/2015 | |
|---|---|---|---|---|
| Priority: | Medium | Due date: | ||
| Assignee: | Dan Gillean | % Done: | 0% | |
| Category: | Search / Browse | |||
| Target version: | Release 2.3.0 | |||
| Google Code Legacy ID: | Tested version: | 2.3 | ||
| Sponsored: | No | Requires documentation: |
Description
Reported by Glenn Dingwall (CVA):
1) On the search results page, if you toggle the top-level/all facet filter to "top-level", AND there are no top level descriptions in the results, the facet filter bar disappears (presumably because there are no results to display) and you can't restore the toggle back to "all descriptions"
2) The background for the radio button section doesn't extend to the full width of the facet filter bar, making it look a little sloppy
History
#1 Updated by Jesús García Crespo almost 7 years ago
I can't reproduce, can you send some screenshots?
#2 Updated by Jesús García Crespo almost 7 years ago
- Status changed from New to Code Review
- Assignee set to José Raddaoui Marín
https://github.com/artefactual/atom/pull/231
... with two commits for both cases described by Glenn Dingwall.
#3 Updated by Jesús García Crespo almost 7 years ago
- Status changed from Code Review to QA/Review
- Assignee changed from José Raddaoui Marín to Dan Gillean
Ready for QA. Please test branch dev/issue-8840-toplevel-facet.
#4 Updated by José Raddaoui Marín almost 7 years ago
- Status changed from QA/Review to Feedback
- Assignee changed from Dan Gillean to Jesús García Crespo
Looks good!
#5 Updated by Jesús García Crespo almost 7 years ago
- Status changed from Feedback to QA/Review
- Assignee changed from Jesús García Crespo to Dan Gillean
#6 Updated by Dan Gillean almost 7 years ago
- File old-LOD.png added
- File current-LOD.png added
- Subject changed from top-level descriptions/all descriptions radio button to Improve top-level descriptions/all descriptions radio button behavior when limiting results on a search
- Category set to Search / Browse
- Status changed from QA/Review to Feedback
- Assignee changed from Dan Gillean to Holly Becker
- Target version set to Release 2.3.0
The new behavior of the Top level of descriptions filter is good - but unfortunately, it appears to have broken the functionality of the LOD facets below.
See screenshots attached.
#7 Updated by Jesús García Crespo almost 7 years ago
- Status changed from Feedback to QA/Review
- Assignee changed from Holly Becker to Dan Gillean
Please, test again!
Fixed here: https://github.com/artefactual/atom/commit/ddf6ef4fb70bc1924b553c03b9140e97185dd2be
#8 Updated by Dan Gillean over 6 years ago
- Status changed from QA/Review to Verified
Little bit hard to tell with the complications from #8889, but as far as I can tell, this is all good! I think you should merge.