Bug #8981

CSV import breaks when php 5.3 is used in AtoM 2.2

Added by Dan Gillean about 5 years ago. Updated almost 5 years ago.

Status:VerifiedStart date:09/21/2015
Priority:MediumDue date:
Assignee:Dan Gillean% Done:

0%

Category:CSV import
Target version:Release 2.2.1
Google Code Legacy ID: Tested version:2.2
Sponsored:No Requires documentation:

Description

Based on this user report by Zac Howarth, in the user forum: https://groups.google.com/d/msg/ica-atom-users/-kKNkmVTBWU/JjRkA3VREgAJ

The following error was reported:

PHP Fatal error:  Cannot access parent:: when no class scope is active in [atom-path]/lib/task/import/csvImportTask.class.php on line 1024

According to Jesus (and copied by me to the forum):

...the code in question all runs within a closure, and PHP 5.3 does not support class scope in closures. We recommend upgrading to PHP 5.5, which is the default PHP version included in Ubuntu 14.04. If you are still running 12.04, you can update your PHP version easily via this ppa:ppa:ondrej/php5

Zac has confirmed that the PHP upgrade resolved the issue.

However, Jesus notes that we should not be changing the requirements post-release. Since the new treeview will require at least PHP 5.4+ in AtoM 2.3, we will update the 2.3 requirements, but he suggests that we fix this issue for the 2.2.1 release, and maintain compatibility with our current requirements recommendations.

Assigning to him, because it was his brilliant idea :)

History

#1 Updated by Dan Gillean about 5 years ago

  • Assignee changed from Jesús García Crespo to Mike Cantelon

JGC has called out MC for writing this code. Assigning to him.

#2 Updated by Mike Cantelon about 5 years ago

  • Status changed from New to Code Review
  • Assignee changed from Mike Cantelon to Jesús García Crespo

#3 Updated by Mike Cantelon about 5 years ago

  • Status changed from Code Review to QA/Review
  • Assignee changed from Jesús García Crespo to Dan Gillean

Merged.

#4 Updated by Dan Gillean almost 5 years ago

  • Status changed from QA/Review to Verified

Also available in: Atom PDF