Bug #9051

AtoM breaks with STRICT_TRANS_TABLES

Added by Jesús García Crespo almost 4 years ago. Updated 4 months ago.

Status:VerifiedStart date:10/13/2015
Priority:MediumDue date:
Assignee:-% Done:

0%

Category:Installation
Target version:Release 2.5.0
Google Code Legacy ID: Tested version:
Sponsored:No Requires documentation:

Description

User report: https://groups.google.com/d/msg/ica-atom-users/8UyHZDt1Ac8/C2FbBE8DDAAJ

This may not be urgent but we should probably ask users to stop using STRICT_TRANS_TABLES in MySQL.
I suggest to find a solution for the culture field being truncated and then do some mores testing to evaluate the amount of work needed.

History

#1 Updated by David Juhasz almost 4 years ago

This seems to be related to the use of "ca@valencia" as a language code in the fixtures, e.g.:
https://github.com/artefactual/atom/blob/qa/2.3.x/data/fixtures/acl.yml#L9

There seems to be no ISO 639-3 code for Valencian, probably due to the Valencian language controversy

There's also two different keys for Brazilian Portuguese: "pt-BR" and "pt_BR", and a non-standard key for "de-CH" (an underscore is the current convention, i.e. "de_CH"). I think these discrepancies point to a bigger discussion about what language codes can be supported in AtoM.

#2 Updated by Sarah Romkey almost 4 years ago

  • Target version deleted (Release 2.2.1)

#3 Updated by Jesús García Crespo over 3 years ago

  • Assignee deleted (Jesús García Crespo)

#5 Updated by David Juhasz 7 months ago

  • Target version set to Release 2.5.0

Targeting for 2.5.0 for Ubuntu 18.04 compatibility. Ubuntu 18.04 packages MySQL Server 5.7.24 which has STRICT_TRANS_TABLES on by default (Ref: https://dev.mysql.com/doc/refman/5.7/en/sql-mode.html#sqlmode_strict_trans_tables).

#6 Updated by David Juhasz 7 months ago

I recommend we increase the length of the culture column to 16 characters to accommodate the "ca@valencia" string.

We should still do some work to standardize some of the other labels "pt_BR" vs. "pt-BR".

#7 Updated by Mike Cantelon 5 months ago

Need to increase the size of source_culture columns as well.

#8 Updated by Mike Cantelon 5 months ago

  • Status changed from New to Code Review

#9 Updated by Steve Breker 5 months ago

  • Status changed from Code Review to Feedback

CR complete - Looks good Mike!

#10 Updated by Mike Cantelon 5 months ago

  • Status changed from Feedback to QA/Review
  • Assignee set to Dan Gillean

Merged into qa/2.5.x for QA.

#11 Updated by Dan Gillean 4 months ago

  • Assignee deleted (Dan Gillean)

#12 Updated by Dan Gillean 4 months ago

  • Status changed from QA/Review to Verified

Also available in: Atom PDF