Bug #9081
Publication status duplication when editing archival descriptions
| Status: | Verified | Start date: | 10/20/2015 | |
|---|---|---|---|---|
| Priority: | High | Due date: | ||
| Assignee: | Dan Gillean | % Done: | 0% | |
| Category: | Information object | |||
| Target version: | Release 2.3.0 | |||
| Google Code Legacy ID: | Tested version: | 1.3.1, 2.0.0, 2.0.1, 2.1, 2.1.1, 2.1.2, 2.2, 2.3 | ||
| Sponsored: | No | Requires documentation: |
Description
To reproduce:
- Create new archival description (draft)
- Edit the same archival description:
- Add a child in the 'Add new child levels' table
- Change publication status to published
- Save
Result:
- Go to Admin menu, Description updates
- Select 'Draft' in the left column filter and search
- Child record appears as a result
- Select 'Published' in the left column filter and search
- Child record appears as a result too
Expected result:
- Child record appears only when published or all are selected
Note:
It may be other ways to reproduce this issue editing both sections. We're setting the publication status in three places when childs are added:
https://github.com/artefactual/atom/blob/qa/2.3.x/apps/qubit/modules/informationobject/actions/editAction.class.php#L692
https://github.com/artefactual/atom/blob/qa/2.3.x/apps/qubit/modules/informationobject/actions/editAction.class.php#L770
https://github.com/artefactual/atom/blob/qa/2.3.x/apps/qubit/modules/informationobject/actions/editAction.class.php#L786
History
#4 Updated by José Raddaoui Marín over 6 years ago
- Description updated (diff)
#5 Updated by José Raddaoui Marín over 6 years ago
- Description updated (diff)
#6 Updated by José Raddaoui Marín over 6 years ago
It will happen always when the publication status is changed and new childs added at the same time. It makes more sense to think that a user can add some childs and change the publication status of the parent description (from published to draft) because of the new childs.
#7 Updated by José Raddaoui Marín over 6 years ago
- Status changed from New to Code Review
- Assignee changed from José Raddaoui Marín to Jesús García Crespo
Ready for code review: PR 248
#8 Updated by José Raddaoui Marín over 6 years ago
- Status changed from Code Review to QA/Review
- Assignee changed from Jesús García Crespo to Dan Gillean
Merged in qa/2.3.x.
Please, let me know if you think I should add it to the stable/2.2.x branch for the 2.2.1 release.
#9 Updated by Dan Gillean over 6 years ago
- Status changed from QA/Review to Verified
Tested this in 2.3, following the instructions above, and did not have any issues - in description updates, could only find the resources with the published filter (not showing up in both).
I think we could merge this one back to 2.2.1!
#10 Updated by José Raddaoui Marín over 6 years ago
Thanks Dan.
Merged in stable/2.2.x