Bug #9156

EAD import: <originalsloc> does not support nested <address> elements

Added by Dan Gillean over 6 years ago. Updated almost 6 years ago.

Status:VerifiedStart date:11/17/2015
Priority:MediumDue date:
Assignee:Dan Gillean% Done:

0%

Category:EAD
Target version:Release 2.3.0
Google Code Legacy ID: Tested version:2.2, 2.3
Sponsored:No Requires documentation:

Description

First reported in the User Forum (2015-11-17): https://groups.google.com/d/msg/ica-atom-users/vW03wc3caU4/yCBfXQ-GBwAJ

Sample use case:

<originalsloc encodinganalog="535">
  <p>Tate Gallery Archive (TAM 21C microfiche);</p>
  <address>
     <addressline>London;</addressline>
     <addressline>England;</addressline>
     <addressline>enk</addressline>
   </address>
</originalsloc>

EAD 2002 XML indicates that this is valid EAD - see: http://www.loc.gov/ead/tglib/elements/originalsloc.html

Resulting error

  • Upon import, all elements nested in the <address> within the <originalsloc> element are lost. Only text contained in a paragraph element is actually imported.

Expected result

  • Address information for location of originals is imported.

History

#1 Updated by Mike Cantelon about 6 years ago

  • Status changed from New to Code Review
  • Assignee changed from Mike Cantelon to Nick Wilkinson

Created pull request for code review:

https://github.com/artefactual/atom/pull/336

#2 Updated by Mike Gale about 6 years ago

  • Status changed from Code Review to Feedback
  • Assignee changed from Nick Wilkinson to Mike Cantelon

I CR'd. I had a minor comment for the code and asked for some more comments to tell what's going on. Other than that, if Dan is cool with this strategy and this new code works still with AtoM generated EAD, looks good to me.

#3 Updated by Mike Cantelon about 6 years ago

  • Status changed from Feedback to QA/Review
  • Assignee changed from Mike Cantelon to Nick Wilkinson

Merged in qa/2.3.x and ready for QA.

#4 Updated by Nick Wilkinson about 6 years ago

  • Assignee changed from Nick Wilkinson to Dan Gillean

#5 Updated by Dan Gillean almost 6 years ago

  • Status changed from QA/Review to Verified
  • Target version set to Release 2.3.0

Also available in: Atom PDF