Bug #9266

Actor bioghist always fully expanded when bullets are used

Added by Dan Gillean over 6 years ago. Updated over 6 years ago.

Status:VerifiedStart date:12/07/2015
Priority:MediumDue date:
Assignee:Dan Gillean% Done:

0%

Category:Actor
Target version:Release 2.3.0
Google Code Legacy ID: Tested version:2.2, 2.3
Sponsored:Yes Requires documentation:No

Description

To reproduce:

  • Create an authority record, and add a paragraph to the History field. Save.
  • Note that when more than 3 lines are included, the rest of the content is collapsed and hidden, and can be expanded by users.
  • Now create another authority record with a block of text in the History field, including bullets (use an asterix - AtoM will convert them into bullets).
  • Save and compare the two
Error encountered
  • When bullets are used in the bioghist, extended content does not collapse as expected
  • This is visible in the related description as well, when an actor is linked to an information object
Expected result
  • Bullets do not affect behavior of the expand/collapse JS

auth-no-bullets.png (39 KB) Dan Gillean, 12/09/2015 01:47 PM

auth-with-bullets.png (67.2 KB) Dan Gillean, 12/09/2015 01:47 PM

bullet-test.png (124 KB) Dan Gillean, 02/01/2016 07:00 PM

History

#2 Updated by Nick Wilkinson over 6 years ago

  • Assignee changed from Nick Wilkinson to Mike Gale

#3 Updated by Mike Gale over 6 years ago

  • Assignee changed from Mike Gale to José Raddaoui Marín

#4 Updated by José Raddaoui Marín over 6 years ago

To add a general solution, we've decided to apply the expander to all fields except those with only a list as a child.

#5 Updated by José Raddaoui Marín over 6 years ago

  • Status changed from New to Code Review
  • Assignee changed from José Raddaoui Marín to Nick Wilkinson

#6 Updated by Jesús García Crespo over 6 years ago

  • Status changed from Code Review to Feedback
  • Assignee changed from Nick Wilkinson to José Raddaoui Marín

LGTM

#7 Updated by José Raddaoui Marín over 6 years ago

  • Status changed from Feedback to QA/Review
  • Assignee changed from José Raddaoui Marín to Dan Gillean

Merged in qa/2.3.x

#8 Updated by Dan Gillean over 6 years ago

  • File bullet-test.png added
  • Status changed from QA/Review to Feedback
  • Assignee changed from Dan Gillean to José Raddaoui Marín
  • Target version set to Release 2.3.0
  • Sponsored changed from No to Yes
  • Requires documentation set to No

Hi Radda,

Can you please clarify the exact use cases? As I understood it, the list should only NOT collapse if there is just one list - so this covers access points, or a section where the user only adds a long list, with no mixed content (e.g. free text). From what I thought, based on talking to you, that means:

  • If there is more than 1 list, it should still collapse
  • If there is a combination of free text and a list, it should collapse

Is this accurate? If so, then some of my initial tests have failed - please see the attached image with examples.

#9 Updated by José Raddaoui Marín over 6 years ago

  • Status changed from Feedback to QA/Review
  • Assignee changed from José Raddaoui Marín to Dan Gillean

Hi Dan, that's accurate. The only missing thing is that the expander kicks in when the field is more than 255 chars long. I think some of the fields tested don't have that length.

Also, 'Subjects access points' is marked as a failure in the tests, but I think it's okay.

#10 Updated by Dan Gillean over 6 years ago

Ahhh! I thought it was about no. of lines not character length, but given that device width affects line length, that makes perfect sense. You're right about the subjects case too - I noticed that last night after I had posted the image and was going to update the ticket this morning to mention that. It was my mistake in annotating the image; sorry!

I'll re-test and update the ticket accordingly.

#11 Updated by Dan Gillean over 6 years ago

  • Status changed from QA/Review to Verified

Looks good!

Also available in: Atom PDF