Bug #9431

Users can specify crazy, invalid URLs when using tools:purge task

Added by Mike Gale over 6 years ago. Updated about 6 years ago.

Status:VerifiedStart date:02/10/2016
Priority:MediumDue date:
Assignee:Sara Allain% Done:

0%

Category:CLI tools
Target version:Release 2.3.0
Google Code Legacy ID: Tested version:
Sponsored:No Requires documentation:

Description

This was causing issues in our EAD / finding aid generation because it uses the site base URL and inserts it into XML.

To reproduce:
  1. Run php symfony tools:purge --url="\"http://hi.com\""
  2. The base URL will be accepted as "http://hi.com" with quotes around it
  3. Create a record in AtoM
  4. Export the EAD

Result:

The XML will choke since the quote in the base URL is escaping the string when EAD is being generated.

Expected result:

For us to do validation in tools:purge to make sure malformed URLs don't sneak in that way

History

#1 Updated by Mike Gale over 6 years ago

  • Status changed from New to Code Review
  • Assignee changed from Mike Gale to Jesús García Crespo

#2 Updated by Jesús García Crespo over 6 years ago

  • Status changed from Code Review to Feedback
  • Assignee changed from Jesús García Crespo to Mike Gale

LGTM

#3 Updated by Mike Gale over 6 years ago

  • Status changed from Feedback to QA/Review
  • Assignee changed from Mike Gale to Dan Gillean

#4 Updated by Sara Allain about 6 years ago

  • Status changed from QA/Review to Verified
  • Assignee changed from Dan Gillean to Sara Allain

Looks good!

Also available in: Atom PDF