Bug #9595

Regression: pager not showing on actor and repository browse pages

Added by Dan Gillean about 6 years ago. Updated about 6 years ago.

Status:VerifiedStart date:03/18/2016
Priority:HighDue date:
Assignee:-% Done:

0%

Category:Search / Browse
Target version:Release 2.3.0
Google Code Legacy ID: Tested version:2.3
Sponsored:No Requires documentation:No

Description

  • Make sure you have more than 10 authority records and repositories
  • Navigate to browse pages for each entity
Error encountered
  • Results are more than default page number, but no pager is provided
Expected result
  • Pager is present and works

Note this could be affecting other entities too. I just didn't have the data to check at the moment.

History

#1 Updated by Mike Gale about 6 years ago

  • Assignee changed from Jesús García Crespo to Mike Gale

The bug was introduced here: https://github.com/artefactual/atom/commit/526fe011a8b5b722bc3e0488882f561bf71fafa8#diff-2f297f2615325205eef4fa376e6d56f2L142

We're now setting the limit variable in $this->limit instead of $request->limit, and some module browse actions are still using the old $request->limit (e.g. https://github.com/artefactual/atom/blob/qa/2.3.x/apps/qubit/modules/actor/actions/browseAction.class.php#L115)

I'll go through all the 'browse' menu items, and make sure they are all using $this->limit now.

#2 Updated by Mike Gale about 6 years ago

  • Status changed from New to Code Review
  • Assignee changed from Mike Gale to José Raddaoui Marín

https://github.com/artefactual/atom/pull/292

One thing to note, Radda, is that for some reason the page limit for digitalobject/browse was hard coded to 30 results. Dan thinks we should go off the admin page limit setting instead, so I did that for now. If you have a reason why we should keep it 30, let me know. Thanks.

#3 Updated by José Raddaoui Marín about 6 years ago

  • Status changed from Code Review to Feedback
  • Assignee changed from José Raddaoui Marín to Mike Gale

Looks good. Thanks Mike!

#4 Updated by Mike Gale about 6 years ago

  • Status changed from Feedback to QA/Review
  • Assignee changed from Mike Gale to Dan Gillean

merged qa/2.3.x
4b7a4e0277cb4abc47e58242909d936cf8ee5694

#5 Updated by Dan Gillean about 6 years ago

  • Status changed from QA/Review to Verified
  • Assignee deleted (Dan Gillean)

phew. thanks.

Also available in: Atom PDF