Feature #9699

PDF download UI improvements

Added by José Raddaoui Marín over 4 years ago. Updated almost 3 years ago.

Status:VerifiedStart date:01/28/2016
Priority:MediumDue date:
Assignee:José Raddaoui Marín% Done:

0%

Category:Information objectEstimated time:6.00 hours
Target version:Release 2.4.0
Google Code Legacy ID: Tested version:
Sponsored:Yes Requires documentation:

Description

  • Improve Download option UI in sidebar for end users
    • Turn into button; use PDF icon for end users
  • Display link to PDF in Finding aids field

Related issues

Related to Access to Memory (AtoM) - Task #9764: Upgrade FontAwesome to v.4.6.1 Verified 04/30/2016

History

#2 Updated by José Raddaoui Marín over 4 years ago

About the PDF icon, we're currently using Fontawesome 3.2.1 which doesn't have a PDF icon. We could try to upgrade to Fontawesome 4.5, where you can find one, or add an individual file for this case.

The Fontawesome upgrade doesn't look too hard, so I think we could make it in the time remaining for this features. At the moment the button is still using the download icon.

#3 Updated by José Raddaoui Marín over 4 years ago

  • Status changed from New to Code Review
  • Assignee changed from José Raddaoui Marín to Jesús García Crespo

Hi Sevein, I've added the changes for this feature to PR 310. Please, take a look and assign it to Dan if do you think it's good or to me if it needs some changes. Thanks!

#4 Updated by Jesús García Crespo over 4 years ago

  • Status changed from Code Review to In progress

LGTM

#5 Updated by José Raddaoui Marín over 4 years ago

  • Status changed from In progress to QA/Review
  • Assignee changed from Jesús García Crespo to Dan Gillean

#6 Updated by José Raddaoui Marín about 4 years ago

Hi Sevein, I've updated Fontawesome to v.4.6.1 and used the PDF icon in the finding aid download button as requested. Please, could you take a look to the last couple of commits in the same PR? Thanks.

#7 Updated by José Raddaoui Marín about 4 years ago

  • Status changed from QA/Review to Code Review
  • Assignee changed from Dan Gillean to Jesús García Crespo

#8 Updated by Jesús García Crespo about 4 years ago

  • Status changed from Code Review to Feedback
  • Assignee changed from Jesús García Crespo to José Raddaoui Marín

I think that we should do the FontAwesome work in a separate PR, then we merge into qa/2.3.x and rebase your branch afterwards. I know it's a hassle but that branch is going to become a beast otherwise.

#9 Updated by José Raddaoui Marín about 4 years ago

  • Related to Task #9764: Upgrade FontAwesome to v.4.6.1 added

#10 Updated by José Raddaoui Marín about 4 years ago

  • Status changed from Feedback to Code Review
  • Assignee changed from José Raddaoui Marín to Jesús García Crespo

Thanks Sevein. I've created another ticket and another PR for that. Please, take a look to both PR when you can. I'll fix the branch used in PR 310 after we merge PR 329 in qa/2.3.x.

#11 Updated by Jesús García Crespo about 4 years ago

  • Status changed from Code Review to In progress
  • Assignee changed from Jesús García Crespo to José Raddaoui Marín

#12 Updated by Dan Gillean about 4 years ago

  • Status changed from In progress to Verified

#14 Updated by Dan Gillean almost 3 years ago

  • Requires documentation deleted (Yes)

Also available in: Atom PDF