Bug #9718

Date range search no longer validates for correct date format, returns fatal error if incorrect date format entered

Added by Dan Gillean about 6 years ago. Updated about 6 years ago.

Status:VerifiedStart date:04/18/2016
Priority:MediumDue date:
Assignee:Dan Gillean% Done:

0%

Category:Search / Browse
Target version:Release 2.3.0
Google Code Legacy ID: Tested version:2.3
Sponsored:No Requires documentation:

Description

  • Navigate to the advanced search panel in 2.3
  • In the date range, enter YYYYMMDD values - without dashes - into the start and end date values
  • Perform your search
Resulting error
  • No formatting validation
  • White screen
  • Fatal error
  • Nginx log:
PHP message: PHP Fatal error:  Call to a member function getNbResults() on a non-object in /usr/share/nginx/atom/apps/qubit/modules/informationobject/templates/browseSuccess.php on line 9" while reading response header from upstream, client: 192.168.33.1, server: _, request: "GET /qubit_dev.php/informationobject/browse?showAdvanced=1&topLod=0&startDate=19990101&endDate=20051231&rangeType=inclusive HTTP/1.1", upstream: "fastcgi://unix:/var/run/php5-fpm.atom.sock:", host: "192.168.33.10", referrer: "http://192.168.33.10/qubit_dev.php/informationobject/browse?showAdvanced=1&topLod=0" 

Expected result

  • In previous versions, we would provide the user with a warning if the parameters entered were not properly formed: see attached image
  • We should still do this
  • No fatal error

date-range-error.png (13.4 KB) Dan Gillean, 04/18/2016 08:04 PM

History

#1 Updated by José Raddaoui Marín about 6 years ago

  • Status changed from New to Code Review
  • Assignee changed from José Raddaoui Marín to Nick Wilkinson

Ready for code review in PR 315

#2 Updated by Nick Wilkinson about 6 years ago

  • Assignee changed from Nick Wilkinson to Mike Gale

#3 Updated by Mike Gale about 6 years ago

  • Assignee changed from Mike Gale to José Raddaoui Marín

+1

#4 Updated by José Raddaoui Marín about 6 years ago

  • Status changed from Code Review to QA/Review
  • Assignee changed from José Raddaoui Marín to Dan Gillean

Merged in qa/2.3.x

#5 Updated by Dan Gillean about 6 years ago

  • Status changed from QA/Review to Verified

Also available in: Atom PDF